Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double-free in decoder_pkey.c #13473

Closed
wants to merge 1 commit into from

Conversation

@gotthardp
Copy link
Contributor

@gotthardp gotthardp commented Nov 22, 2020

Fixes #13472. The decoderctx has to be initialized in every cycle as its constructor may not be called due to lazy evaluation of the if-condition.

CLA: trivial

Fix for the issue #13472. The decoderctx has to be initialized in every
cycle as its constructor may not be called due to lazy evaluation of
the if-condition.

CLA: trivial
Copy link
Member

@levitte levitte left a comment

Good catch!

@levitte levitte modified the milestones: 3.0.0, 3.0.0 beta1 Nov 23, 2020
@levitte levitte added this to In progress in 3.0 New Core + FIPS via automation Nov 23, 2020
Copy link
Contributor

@paulidale paulidale left a comment

Agreed this is trivial.

3.0 New Core + FIPS automation moved this from In progress to Reviewer approved Nov 23, 2020
@paulidale
Copy link
Contributor

@paulidale paulidale commented Nov 23, 2020

Note: Travis CI didn't run because we're out of credits.

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Nov 24, 2020

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@levitte
Copy link
Member

@levitte levitte commented Nov 24, 2020

Merged

2236525 Fix double-free in decoder_pkey.c

@levitte levitte closed this Nov 24, 2020
3.0 New Core + FIPS automation moved this from Reviewer approved to Done Nov 24, 2020
openssl-machine pushed a commit that referenced this pull request Nov 24, 2020
Fix for the issue #13472. The decoderctx has to be initialized in every
cycle as its constructor may not be called due to lazy evaluation of
the if-condition.

CLA: trivial

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #13473)
@nelsonopenssl nelsonopenssl added this to review pending in 3.0.0 estimator Dec 1, 2020
@nelsonopenssl nelsonopenssl moved this from review pending to Done in 3.0.0 estimator Dec 1, 2020
@gotthardp gotthardp deleted the gotthardp:fix_double_free branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

4 participants