Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Make our test data binary #13477

Closed
wants to merge 1 commit into from
Closed

TEST: Make our test data binary #13477

wants to merge 1 commit into from

Conversation

@levitte
Copy link
Member

@levitte levitte commented Nov 23, 2020

Our test data (test/data.txt and test/data2.txt) are text files, but
declaring them binary means that there will be no line ending
transformation done on them. This is necessary for testing on
non-Unix platforms, where certain tests could otherwise give results
that don't match expected results.

Fixes #13474

Our test data (test/data.txt and test/data2.txt) are text files, but
declaring them binary means that there will be no line ending
transformation done on them.  This is necessary for testing on
non-Unix platforms, where certain tests could otherwise give results
that don't match expected results.

Fixes #13474
@supernoodled
Copy link

@supernoodled supernoodled commented Nov 23, 2020

Result:

All tests successful.
Files=224, Tests=3430, 897 wallclock secs (11.38 usr + 0.98 sys = 12.36 CPU)
Result: PASS

@levitte
Copy link
Member Author

@levitte levitte commented Nov 23, 2020

Result:

Cool, thank you for testing

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Nov 24, 2020

This pull request is ready to merge

@levitte
Copy link
Member Author

@levitte levitte commented Nov 24, 2020

Merged

c150a94 TEST: Make our test data binary

@levitte levitte closed this Nov 24, 2020
@levitte levitte deleted the levitte:fix-13474 branch Nov 24, 2020
openssl-machine pushed a commit that referenced this pull request Nov 24, 2020
Our test data (test/data.txt and test/data2.txt) are text files, but
declaring them binary means that there will be no line ending
transformation done on them.  This is necessary for testing on
non-Unix platforms, where certain tests could otherwise give results
that don't match expected results.

Fixes #13474

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #13477)
@nelsonopenssl nelsonopenssl added this to review pending in 3.0.0 estimator Dec 1, 2020
@nelsonopenssl nelsonopenssl moved this from review pending to Ready to merge in 3.0.0 estimator Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.0.0 estimator
Ready to merge
Linked issues

Successfully merging this pull request may close these issues.

4 participants