Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate the -dsaparam option in the dhparam app #13485

Closed

Conversation

@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Nov 23, 2020

The -dsaparam option was deprecated because it was previously using
deprecated functions in order to operate. This is no longer the case
and therefore does not need to be deprecated.

The -dsaparam option was deprecated because it was previously using
deprecated functions in order to operate. This is no longer the case
and therefore does not need to be deprecated.
@mattcaswell
Copy link
Member Author

@mattcaswell mattcaswell commented Nov 23, 2020

This fixes a failure on master with "no-deprecated" builds

@t8m
t8m approved these changes Nov 23, 2020
Copy link
Member

@t8m t8m left a comment

LGTM

@mattcaswell
Copy link
Member Author

@mattcaswell mattcaswell commented Nov 24, 2020

close/reopen to run github ci

@mattcaswell mattcaswell reopened this Nov 24, 2020
@openssl-machine
Copy link

@openssl-machine openssl-machine commented Nov 24, 2020

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@mattcaswell
Copy link
Member Author

@mattcaswell mattcaswell commented Nov 24, 2020

The CI failures are unrelated to this PR. (The minimal build should be fixed by #13497...I can't reproduce the sanitizers failure, but it exists prior to this PR).

@mattcaswell
Copy link
Member Author

@mattcaswell mattcaswell commented Nov 24, 2020

Pushed. Thanks.

openssl-machine pushed a commit that referenced this pull request Nov 24, 2020
The -dsaparam option was deprecated because it was previously using
deprecated functions in order to operate. This is no longer the case
and therefore does not need to be deprecated.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #13485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants