Undeprecate the -dsaparam option in the dhparam app #13485
Closed
Conversation
The -dsaparam option was deprecated because it was previously using deprecated functions in order to operate. This is no longer the case and therefore does not need to be deprecated.
|
This fixes a failure on master with "no-deprecated" builds |
|
LGTM |
|
close/reopen to run github ci |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
|
The CI failures are unrelated to this PR. (The minimal build should be fixed by #13497...I can't reproduce the sanitizers failure, but it exists prior to this PR). |
|
Pushed. Thanks. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2020
The -dsaparam option was deprecated because it was previously using deprecated functions in order to operate. This is no longer the case and therefore does not need to be deprecated. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #13485)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The -dsaparam option was deprecated because it was previously using
deprecated functions in order to operate. This is no longer the case
and therefore does not need to be deprecated.