Deprecate DSA harder (cont. from #13187) #13638
Conversation
|
There's one test error that's due to a lack of MSBLOB / PVK encoders... this should have been discovered earlier, but a fault in |
|
Your additions/changes look okay to me. |
|
This is now pending on #13645 |
|
Actually as far as I remember DSA_SIG was not intended to be deprecated in 3.0 when we discussed the additional deprecations on the OTC meetings. |
|
Rebase, because #13645 got merged |
|
Apart from the usual sanitizer, CIs are happy. Good enough for a review? |
|
There are some leftovers from the attempt to deprecate DSA_SIG. |
|
LGTM |
|
I rebased this to be on top of the newly merged #13661 |
|
Still approved, just for the record. |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #13638)
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #13638)
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #13638)
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #13638)
This deprecates all functions that deal with the type DSA.
There was an intention to deprecate DSA_SIG as well, but we don't have a clear replacement, so that will have to happen separately.
Amends #13187