Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DSA harder (cont. from #13187) #13638

Closed
wants to merge 18 commits into from
Closed

Conversation

@levitte
Copy link
Member

@levitte levitte commented Dec 8, 2020

This deprecates all functions that deal with the type DSA.
There was an intention to deprecate DSA_SIG as well, but we don't have a clear replacement, so that will have to happen separately.


Amends #13187

@levitte levitte mentioned this pull request Dec 8, 2020
2 of 2 tasks complete
@levitte
Copy link
Member Author

@levitte levitte commented Dec 8, 2020

There's one test error that's due to a lack of MSBLOB / PVK encoders... this should have been discovered earlier, but a fault in test/recipes/15-test_rsa.t had it fail to fail properly. You gotta appreciate the irony...
That will be fixed in a separate PR, on which this one will have to depend.

Copy link
Contributor

@paulidale paulidale left a comment

Your additions/changes look okay to me.
I won't approve since a fair portion of this is mine.

@levitte levitte changed the title Deprecate DSA harder (cont. from #13187) [Pending on #13645] Deprecate DSA harder (cont. from #13187) Dec 9, 2020
@levitte
Copy link
Member Author

@levitte levitte commented Dec 9, 2020

This is now pending on #13645

@t8m
Copy link
Member

@t8m t8m commented Dec 9, 2020

Actually as far as I remember DSA_SIG was not intended to be deprecated in 3.0 when we discussed the additional deprecations on the OTC meetings.

@levitte
Copy link
Member Author

@levitte levitte commented Dec 9, 2020

Actually as far as I remember DSA_SIG was not intended to be deprecated in 3.0 when we discussed the additional deprecations on the OTC meetings.

Yup, that's even written up in #13121. The effort in #13187 was a bit over-zealous... that's ok, it was easy to fix.

@levitte levitte force-pushed the levitte:paulidale-dsa branch from b98ba53 to 084a65b Dec 15, 2020
@levitte
Copy link
Member Author

@levitte levitte commented Dec 15, 2020

Rebase, because #13645 got merged

@levitte levitte changed the title [Pending on #13645] Deprecate DSA harder (cont. from #13187) Deprecate DSA harder (cont. from #13187) Dec 15, 2020
@levitte
Copy link
Member Author

@levitte levitte commented Dec 16, 2020

Apart from the usual sanitizer, CIs are happy. Good enough for a review?

Copy link
Member

@t8m t8m left a comment

There are some leftovers from the attempt to deprecate DSA_SIG.

apps/dsa.c Outdated Show resolved Hide resolved
apps/req.c Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
doc/man3/d2i_X509.pod Show resolved Hide resolved
fuzz/asn1.c Show resolved Hide resolved
doc/man3/d2i_RSAPrivateKey.pod Outdated Show resolved Hide resolved
doc/man3/DSA_SIG_new.pod Outdated Show resolved Hide resolved
@t8m
t8m approved these changes Dec 16, 2020
Copy link
Member

@t8m t8m left a comment

LGTM

@levitte levitte force-pushed the levitte:paulidale-dsa branch from 696d88a to 3090e6e Dec 17, 2020
@levitte
Copy link
Member Author

@levitte levitte commented Dec 17, 2020

I rebased this to be on top of the newly merged #13661

@t8m
Copy link
Member

@t8m t8m commented Dec 17, 2020

Still approved, just for the record.

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Dec 17, 2020

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

openssl-machine pushed a commit that referenced this pull request Dec 17, 2020
Fixes #13121

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #13638)
openssl-machine pushed a commit that referenced this pull request Dec 17, 2020
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #13638)
openssl-machine pushed a commit that referenced this pull request Dec 17, 2020
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #13638)
openssl-machine pushed a commit that referenced this pull request Dec 17, 2020
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #13638)
openssl-machine pushed a commit that referenced this pull request Dec 17, 2020
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #13638)
@levitte
Copy link
Member Author

@levitte levitte commented Dec 17, 2020

Merged

d6fff34 dsa: documentation deprecation changes
575b36e dsa: fuzzer deprecation changes
4742254 dsa: apps deprecation changes
52c8535 dsa: provider and library deprecation changes
ea78081 dsa: add additional deprecated functions to CHANGES entry.

@levitte levitte closed this Dec 17, 2020
@levitte levitte deleted the levitte:paulidale-dsa branch Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants