Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSSL_PARAM creation in OSSL_STORE_open_ex #13699

Closed
wants to merge 1 commit into from

Conversation

@gotthardp
Copy link
Contributor

@gotthardp gotthardp commented Dec 17, 2020

The params[0].data is set to a non-NULL value, but params[0].data_size remains always zero. This confuses get_string_internal, which creates 1 byte string with uninitialized content.

When OSSL_PARAM_construct_utf8_string is used, the data_size is set correctly.

The params[0].data is set to a non-NULL value, but params[0].data_size
is always zero. This confuses get_string_internal, which creates 1 byte
string with uninitialized content.

When OSSL_PARAM_construct_utf8_string is used, the data_size is set
correctly.
@gotthardp gotthardp force-pushed the gotthardp:fix_store_open_params branch from da39d98 to 2f09a67 Dec 17, 2020
@gotthardp gotthardp requested a review from levitte Dec 17, 2020
@t8m
t8m approved these changes Dec 18, 2020
@openssl-machine
Copy link

@openssl-machine openssl-machine commented Dec 19, 2020

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Dec 19, 2020
The params[0].data is set to a non-NULL value, but params[0].data_size
is always zero. This confuses get_string_internal, which creates 1 byte
string with uninitialized content.

When OSSL_PARAM_construct_utf8_string is used, the data_size is set
correctly.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #13699)
@t8m
Copy link
Member

@t8m t8m commented Dec 19, 2020

Merged to master. Thank you for the contribution!

@t8m t8m closed this Dec 19, 2020
@gotthardp gotthardp deleted the gotthardp:fix_store_open_params branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants