Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop OPENSSL_NO_RSA everywhere #13700

Closed
wants to merge 6 commits into from
Closed

Conversation

@levitte
Copy link
Member

@levitte levitte commented Dec 17, 2020

The configuration option 'no-rsa' was dropped with OpenSSL 1.1.0, so
this is simply a cleanup of the remains.

@levitte levitte force-pushed the levitte:drop-OPENSSL_NO_RSA branch from f0a39e5 to 1d06671 Dec 17, 2020
@paulidale
Copy link
Contributor

@paulidale paulidale commented Dec 18, 2020

CIs are relevant (I think).

apps/speed.c Outdated Show resolved Hide resolved
engines/e_devcrypto.c Show resolved Hide resolved
@levitte
Copy link
Member Author

@levitte levitte commented Dec 18, 2020

CIs are relevant (I think).

Yup. I didn't pay attention that some of the guards were #ifdef rather than #ifndef

@levitte
Copy link
Member Author

@levitte levitte commented Dec 18, 2020

CIs are much happier now

@levitte
Copy link
Member Author

@levitte levitte commented Dec 18, 2020

Fixup added, the logic in apps/speed.c wasn't quite right

@t8m
Copy link
Member

@t8m t8m commented Dec 18, 2020

Hmm, still needs some adjustments probably?

@levitte
Copy link
Member Author

@levitte levitte commented Dec 18, 2020

Yes, those adjustments are in a separate PR, #13706

@levitte levitte changed the title Drop OPENSSL_NO_RSA everywhere [Pending on #13706] Drop OPENSSL_NO_RSA everywhere Dec 18, 2020
@levitte levitte dismissed t8m’s stale review Dec 18, 2020

Will need re-reviewing

@levitte levitte removed the approval: done label Dec 18, 2020
@levitte levitte mentioned this pull request Dec 18, 2020
@kroeckx
Copy link
Member

@kroeckx kroeckx commented Dec 18, 2020

speed.c still has a problem

@levitte levitte force-pushed the levitte:drop-OPENSSL_NO_RSA branch from 5949d27 to 604d362 Dec 19, 2020
@levitte
Copy link
Member Author

@levitte levitte commented Dec 19, 2020

speed.c still has a problem

Unless I missed something, that's fixed by #13706
Ah yup, the changes don't like no-bulk, even with #13706 merged in

@levitte
Copy link
Member Author

@levitte levitte commented Dec 19, 2020

Ah yup, the changes don't like no-bulk, even with #13706 merged in

Fixed, I hope

@t8m
t8m approved these changes Dec 19, 2020
@levitte
Copy link
Member Author

@levitte levitte commented Dec 19, 2020

Hmmm, so perhaps this doesn't need to wait on #13706 after all...

@levitte levitte changed the title [Pending on #13706] Drop OPENSSL_NO_RSA everywhere Drop OPENSSL_NO_RSA everywhere Dec 19, 2020
@levitte levitte force-pushed the levitte:drop-OPENSSL_NO_RSA branch from e84aa4b to b35bb71 Dec 19, 2020
@levitte
Copy link
Member Author

@levitte levitte commented Dec 19, 2020

With #13706 merged, this needed a rebase. There was one small conflict in crypto/asn1/i2d_evp.c which was trivial to clear.

@t8m
Copy link
Member

@t8m t8m commented Dec 20, 2020

@levitte
Copy link
Member Author

@levitte levitte commented Dec 20, 2020

Merged

3a1ee3c Drop OPENSSL_NO_RSA everywhere

@levitte levitte closed this Dec 20, 2020
@levitte levitte deleted the levitte:drop-OPENSSL_NO_RSA branch Dec 20, 2020
openssl-machine pushed a commit that referenced this pull request Dec 20, 2020
The configuration option 'no-rsa' was dropped with OpenSSL 1.1.0, so
this is simply a cleanup of the remains.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from #13700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants