Fix 'no-deprecated' #13706
Fix 'no-deprecated' #13706
Conversation
|
It might be interesting to have a separate CI job that only does I could add that as part of this PR, if that's desirable |
|
Cis are happy |
It would make sense to have such job. And given the run times of the jobs are now very reasonable I think it should not give any problems to have it. It is actually questionable whether the minimal build should include no-deprecated or not. Probably not if we have this new no-deprecated build. |
I agree, since they serve two different purposes |
Commit added |
|
... that broke the minimal job. Fix committed |
|
(I so wanna call this "urgent", so I can rebase #13700 without making it ugly |
Some of the handling of no-deprecated stuff wasn't quite complete, or even plain wrong. This restores i2d_PublicKey() to be able to handle EVP_PKEYs with legacy internal keys. This also refactors the DSA key tests in test/evp_extra_test.c to use EVP functionality entirely.
7e89006
to
d395569
|
Still approved. |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Some of the handling of no-deprecated stuff wasn't quite complete, or even plain wrong. This restores i2d_PublicKey() to be able to handle EVP_PKEYs with legacy internal keys. This also refactors the DSA key tests in test/evp_extra_test.c to use EVP functionality entirely. Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #13706)
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #13706)
Some of the handling of no-deprecated stuff wasn't quite complete, or
even plain wrong.
This restores i2d_PublicKey() to be able to handle EVP_PKEYs with
legacy internal keys.
This also refactors the DSA key tests in test/evp_extra_test.c to use
EVP functionality entirely.