Fetch provided digest once per benchmark #13721
Closed
Conversation
|
The 2nd commit was tested against GOST (engine-provided) and works. |
|
@mattcaswell, could you please take a look at the failing tests? |
|
The connection seem to work well without proxy even for the failing tests |
|
I've removed the commit breaking tests and implemented the cipher prefetch. |
|
Approved subject to the nit being fixed |
apps/speed.c
Outdated
| { | ||
| EVP_CIPHER *cipher = NULL; | ||
|
|
||
| /* Look through providers' digests */ |
mattcaswell
Dec 22, 2020
Member
s/digests/ciphers/
s/digests/ciphers/
beldmit
Dec 22, 2020
Author
Member
Fixed and reworded the commit message. Could you please formally reapprove?
Fixed and reworded the commit message. Could you please formally reapprove?
Partially fixes #13578
|
Reconfirm |
|
This pull request is ready to merge |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Partially fixes #13578
Checklist