Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch provided digest once per benchmark #13721

Closed
wants to merge 1 commit into from
Closed

Conversation

@beldmit
Copy link
Member

@beldmit beldmit commented Dec 21, 2020

Partially fixes #13578

Checklist
  • documentation is added or updated
  • tests are added or updated
apps/speed.c Outdated Show resolved Hide resolved
@beldmit
Copy link
Member Author

@beldmit beldmit commented Dec 21, 2020

The 2nd commit was tested against GOST (engine-provided) and works.

@beldmit
Copy link
Member Author

@beldmit beldmit commented Dec 21, 2020

@mattcaswell, could you please take a look at the failing tests?

@beldmit
Copy link
Member Author

@beldmit beldmit commented Dec 21, 2020

The connection seem to work well without proxy even for the failing tests

@beldmit
Copy link
Member Author

@beldmit beldmit commented Dec 21, 2020

I've removed the commit breaking tests and implemented the cipher prefetch.

apps/speed.c Show resolved Hide resolved
apps/speed.c Show resolved Hide resolved
@beldmit beldmit force-pushed the beldmit:fix_13578 branch from c058890 to e3949b4 Dec 22, 2020
Copy link
Member

@mattcaswell mattcaswell left a comment

Approved subject to the nit being fixed

{
EVP_CIPHER *cipher = NULL;

/* Look through providers' digests */

This comment has been minimized.

@mattcaswell

mattcaswell Dec 22, 2020
Member

s/digests/ciphers/

This comment has been minimized.

@beldmit

beldmit Dec 22, 2020
Author Member

Fixed and reworded the commit message. Could you please formally reapprove?

Partially fixes #13578
@beldmit beldmit force-pushed the beldmit:fix_13578 branch from e3949b4 to b31ef5a Dec 22, 2020
Copy link
Member

@mattcaswell mattcaswell left a comment

Reconfirm

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Dec 23, 2020

This pull request is ready to merge

@beldmit
Copy link
Member Author

@beldmit beldmit commented Dec 23, 2020

Merged. Thanks!

@beldmit beldmit closed this Dec 23, 2020
@beldmit beldmit deleted the beldmit:fix_13578 branch Dec 23, 2020
openssl-machine pushed a commit that referenced this pull request Dec 23, 2020
Partially fixes #13578

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #13721)
@beldmit beldmit mentioned this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants