Rename OSSL_ENCODER_CTX_new_by_EVP_PKEY and OSSL_DECODER_CTX_new_by_EVP_PKEY #14155
Conversation
…VP_PKEY Additional renames done in encoder and decoder implementation to follow the style. Fixes #13622
| const char *input_struct, | ||
| const char *keytype, int selection, | ||
| OSSL_LIB_CTX *libctx, const char *propquery); | ||
| OSSL_DECODER_CTX_new_for_pkey(EVP_PKEY **pkey, |
slontis
Feb 12, 2021
•
Contributor
I think this doc needs to explain what I<pkey> is.
I think this doc needs to explain what I<pkey> is.
t8m
Feb 12, 2021
Author
Member
I can add that although strictly speaking it is off topic for the PR.
I can add that although strictly speaking it is off topic for the PR.
t8m
Feb 12, 2021
Author
Member
PTAL
PTAL
|
Ping? |
|
Yup |
|
This pull request is ready to merge |
|
Merged to master. Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Additional renames done in encoder and decoder implementation
to follow the style.
Fixes #13622
Although in the OTC discussion it was preferred to split out the new and setup for phases into separate functions in the end I've decided not to do it as it is really convenient for the applications to have it like this. I do not see a point in having to always call two functions instead of one and it also conveniently avoids reusing the ctx for multiple encode/decode calls which we might not want to allow anyway.
Checklist