Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OSSL_ENCODER_CTX_new_by_EVP_PKEY and OSSL_DECODER_CTX_new_by_EVP_PKEY #14155

Closed
wants to merge 3 commits into from

Conversation

@t8m
Copy link
Member

@t8m t8m commented Feb 11, 2021

Additional renames done in encoder and decoder implementation
to follow the style.

Fixes #13622

Although in the OTC discussion it was preferred to split out the new and setup for phases into separate functions in the end I've decided not to do it as it is really convenient for the applications to have it like this. I do not see a point in having to always call two functions instead of one and it also conveniently avoids reusing the ctx for multiple encode/decode calls which we might not want to allow anyway.

Checklist
  • documentation is added or updated
…VP_PKEY

Additional renames done in encoder and decoder implementation
to follow the style.

Fixes #13622
const char *input_struct,
const char *keytype, int selection,
OSSL_LIB_CTX *libctx, const char *propquery);
OSSL_DECODER_CTX_new_for_pkey(EVP_PKEY **pkey,

This comment has been minimized.

@slontis

slontis Feb 12, 2021
Contributor

I think this doc needs to explain what I<pkey> is.

This comment has been minimized.

@t8m

t8m Feb 12, 2021
Author Member

I can add that although strictly speaking it is off topic for the PR.

This comment has been minimized.

@t8m

t8m Feb 12, 2021
Author Member

PTAL

This comment has been minimized.

@levitte

levitte Feb 12, 2021
Member

PTAL

I had to look that up!

@t8m t8m force-pushed the t8m:encdec-new-by-rename branch from 706dae4 to 0b7fbb2 Feb 12, 2021
@t8m
Copy link
Member Author

@t8m t8m commented Feb 15, 2021

Ping?

@t8m t8m added this to the 3.0.0 beta1 milestone Feb 15, 2021
@t8m t8m requested a review from levitte Feb 15, 2021
Copy link
Member

@levitte levitte left a comment

Yup

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Feb 16, 2021

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Feb 17, 2021
…VP_PKEY

Additional renames done in encoder and decoder implementation
to follow the style.

Fixes #13622

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #14155)
@t8m
Copy link
Member Author

@t8m t8m commented Feb 17, 2021

Merged to master. Thank you for the review!

@t8m t8m closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants