Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward incompatibility revolving around OSSL_HTTP_REQ_CTX_sendreq_d2i() #14196

Closed
wants to merge 2 commits into from

Conversation

@levitte
Copy link
Member

@levitte levitte commented Feb 16, 2021

The OSSL_HTTP_REQ_CTX API has a few changes compared to the older
OCSP_REQ_CTX API which are not quite obvious at first sight.

The old OCSP_REQ_CTX_nbio_d2i() took three arguments, of which one is
an output argument, and return an int, while the newer
OSSL_HTTP_REQ_CTX_sendreq_d2i() returns the value directly and thereby
takes one less argument.

The mapping from the old to the new wasn't quite right, this corrects
it, along with a couple of X509 macros that needed the same kind of
fix.

…eq_d2i()

The OSSL_HTTP_REQ_CTX API has a few changes compared to the older
OCSP_REQ_CTX API which are not quite obvious at first sight.

The old OCSP_REQ_CTX_nbio_d2i() took three arguments, of which one is
an output argument, and return an int, while the newer
OSSL_HTTP_REQ_CTX_sendreq_d2i() returns the value directly and thereby
takes one less argument.

The mapping from the old to the new wasn't quite right, this corrects
it, along with a couple of X509 macros that needed the same kind of
fix.
@levitte levitte requested a review from DDvO Feb 16, 2021
@levitte levitte mentioned this pull request Feb 16, 2021
1 of 1 task complete
include/openssl/x509.h.in Outdated Show resolved Hide resolved
@DDvO
DDvO approved these changes Feb 16, 2021
Copy link
Contributor

@DDvO DDvO left a comment

LGTM

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Feb 17, 2021

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Feb 17, 2021
…eq_d2i()

The OSSL_HTTP_REQ_CTX API has a few changes compared to the older
OCSP_REQ_CTX API which are not quite obvious at first sight.

The old OCSP_REQ_CTX_nbio_d2i() took three arguments, of which one is
an output argument, and return an int, while the newer
OSSL_HTTP_REQ_CTX_sendreq_d2i() returns the value directly and thereby
takes one less argument.

The mapping from the old to the new wasn't quite right, this corrects
it, along with a couple of X509 macros that needed the same kind of
fix.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #14196)
@levitte
Copy link
Member Author

@levitte levitte commented Feb 17, 2021

Merged

e5ac413 Fix backward incompatibility revolving around OSSL_HTTP_REQ_CTX_sendreq_d2i()

@levitte levitte closed this Feb 17, 2021
@levitte levitte deleted the levitte:fix-remain-http-20210416 branch Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants