Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGES with info about AuthEnvelopedData addition #14456

Closed
wants to merge 1 commit into from

Conversation

@bukka
Copy link
Contributor

@bukka bukka commented Mar 7, 2021

Update of CHANGES.md for #8024 .

CHANGES.md Outdated
@@ -437,6 +437,10 @@ OpenSSL 3.0

*Antonio Iacono*

* Added the AuthEnvelopedData (RFC 5083) with AES-GCM parameter (RFC 5084).

This comment has been minimized.

@t8m

t8m Mar 8, 2021
Member

Could you please expand the text a little? Add something like Added ... support to the CMS implementation. Or something like that to make it clear without having to look into the RFCs or code where the support was added.

This comment has been minimized.

@bukka

bukka Mar 10, 2021
Author Contributor

@t8m Makes sense. I have extended the text a bit. Please let me know if you want me to change anything in it.

@bukka bukka force-pushed the bukka:cms-auth-env-gcm-changes branch from 92ac9a8 to 2a8e031 Mar 10, 2021
@t8m
t8m approved these changes Mar 11, 2021
@t8m
Copy link
Member

@t8m t8m commented Mar 11, 2021

@paulidale Please reapprove

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Mar 12, 2021

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Mar 12, 2021

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Mar 12, 2021
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #14456)
@t8m
Copy link
Member

@t8m t8m commented Mar 12, 2021

Merged to master, thank you.

@t8m t8m closed this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants