Skip to content

/ openssl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash if the pkeyopt doesn't have a value #14496

Closed
wants to merge 1 commit into from
Closed

Don't crash if the pkeyopt doesn't have a value #14496

wants to merge 1 commit into from

Conversation

@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Mar 10, 2021

All pkeyopt's must have a ":" and a value for the option. Not supplying
one can cause a crash

Fixes #14494
@mattcaswell
Don't crash if the pkeyopt doesn't have a value
Loading status checks…
7c698d5 
All pkeyopt's must have a ":" and a value for the option. Not supplying
one can cause a crash

Fixes #14494
@mattcaswell mattcaswell added branch: master approval: review pending branch: 1.1.1 labels Mar 10, 2021
@mattcaswell mattcaswell mentioned this pull request Mar 10, 2021
Closed
@t8m
t8m approved these changes Mar 10, 2021
View changes
@t8m t8m added approval: done and removed approval: review pending labels Mar 10, 2021
@paulidale
paulidale approved these changes Mar 10, 2021
View changes
@openssl-machine
Copy link

@openssl-machine openssl-machine commented Mar 11, 2021

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.
@t8m t8m added approval: ready to merge and removed approval: done labels Mar 11, 2021
@paulidale
Copy link
Contributor

@paulidale paulidale commented Mar 11, 2021

Merged to master.
@paulidale paulidale closed this Mar 11, 2021
openssl-machine pushed a commit that referenced this pull request Mar 11, 2021
@mattcaswell @paulidale
Don't crash if the pkeyopt doesn't have a value
Loading status checks…
3d0b567 
All pkeyopt's must have a ":" and a value for the option. Not supplying
one can cause a crash

Fixes #14494

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #14496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m

@paulidale paulidale

Assignees
No one assigned
Labels
approval: ready to merge branch: 1.1.1 branch: master
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Segmentation fault in genpkey
4 participants
@mattcaswell @openssl-machine @paulidale @t8m