Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: Extend use of untrusted certs in ts app and TS_RESP_verify_signature() #14504

Closed
wants to merge 2 commits into from

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Mar 10, 2021

This is a spin-off from #14503.

  • Let TS_RESP_verify_signature() make use of untrusted certs also from token response.
  • Allow the ts app -untrusted option arg to refer to multiple sources like the cmp app does,
    which motivates moving generally useful functions from apps/cmp.c to apps/lib/apps.c.
  • Clean up the test script 80-test_tsa.t
  • documentation is added or updated
  • tests are added or updated
DDvO added 2 commits Mar 10, 2021
This requires moving generally useful functions from apps/cmp.c to apps/lib/apps.c
@t8m
t8m approved these changes Mar 12, 2021
Copy link
Member

@t8m t8m left a comment

LGTM

@openssl-machine
Copy link

@openssl-machine openssl-machine commented Mar 13, 2021

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Mar 13, 2021
…so from token response

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #14504)
openssl-machine pushed a commit that referenced this pull request Mar 13, 2021
This requires moving generally useful functions from apps/cmp.c to apps/lib/apps.c

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #14504)
@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Mar 13, 2021

Merged - thanks @t8m

@DDvO DDvO closed this Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants