Skip to content

/ openssl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO in test/acvp_test.c related to setting AES-GCM iv. #14525

Closed
wants to merge 1 commit into from
Closed

Remove TODO in test/acvp_test.c related to setting AES-GCM iv. #14525

wants to merge 1 commit into from

Conversation

@slontis
Copy link
Contributor

@slontis slontis commented Mar 12, 2021

Fixes #14330

Checklist
  • documentation is added or updated
  • tests are added or updated
@slontis
Remove TODO in test/acvp_test.c related to setting AES-GCM iv.
Loading status checks…
a02bc1b 
Fixes #14330
@slontis slontis added branch: master approval: review pending triaged: OTC evaluated labels Mar 12, 2021
@slontis slontis added this to the 3.0.0 beta1 milestone Mar 12, 2021
@paulidale
paulidale approved these changes Mar 12, 2021
View changes
@paulidale paulidale added approval: done and removed approval: review pending labels Mar 12, 2021
@openssl-machine
Copy link

@openssl-machine openssl-machine commented Mar 13, 2021

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.
@openssl-machine openssl-machine added approval: ready to merge and removed approval: done labels Mar 13, 2021
@openssl-machine
Copy link

@openssl-machine openssl-machine commented Mar 13, 2021

This pull request is ready to merge
openssl-machine pushed a commit that referenced this pull request Mar 14, 2021
@slontis @paulidale
Remove TODO in test/acvp_test.c related to setting AES-GCM iv.
Loading status checks…
8bfb8f3 
Fixes #14330

Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #14525)
@paulidale
Copy link
Contributor

@paulidale paulidale commented Mar 14, 2021

Merged to master.
@paulidale paulidale closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulidale paulidale

Assignees
No one assigned
Labels
approval: ready to merge branch: master triaged: OTC evaluated
Projects
None yet
Milestone
3.0.0 beta1
Linked issues

Successfully merging this pull request may close these issues.

Resolve or remove TODO in test/acvp_test.c - AES_GCM iv setting
3 participants
@slontis @openssl-machine @paulidale