Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

property_test: use property values that are not used elsewhere #14573

Closed
wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Mar 16, 2021

In test_property_query_value_create() we depend on the property
values to not be created by other test cases. Use such
values.

Urgent as this causes test failures in builds with randomized test order.

Checklist
  • tests are added or updated

In test_property_query_value_create() we depend on the property
values to not be created by other test cases. Use such
values.
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels Mar 16, 2021
@t8m t8m requested a review from paulidale March 16, 2021 12:33
@slontis
Copy link
Member

slontis commented Mar 16, 2021

@paulidale

openssl-machine pushed a commit that referenced this pull request Mar 17, 2021
In test_property_query_value_create() we depend on the property
values to not be created by other test cases. Use such
values.

Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #14573)
@paulidale
Copy link
Contributor

Merged to master. I did a similar fix in #14580 before seeing this one. It had build failures in the test_property test which didn't reproduce here. Time will tell.

@paulidale paulidale closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: review pending This pull request needs review by a committer branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants