Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO comment in EC code. Resolves #14396 #14588

Closed
wants to merge 1 commit into from

Conversation

jon-oracle
Copy link
Contributor

Removes a comment only, no code changes.

Fixes #14396

@paulidale paulidale added approval: review pending This pull request needs review by a committer branch: master Merge to master branch labels Mar 17, 2021
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 17, 2021
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

openssl-machine pushed a commit that referenced this pull request Mar 18, 2021
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #14588)
@paulidale
Copy link
Contributor

Merged to master, thanks for this.

@paulidale paulidale closed this Mar 18, 2021
@jon-oracle jon-oracle deleted the ec-remove-todo branch March 31, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve or remove TODO 3.0 in crypto/evp/ec_support.c
4 participants