25-test_verify.t: correct a test case, add one on self-signed EE cert w/ keyCertSign #15656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad othername name constraint'
…ith key usage keyCertSign also when strict
DDvO
added
approval: otc review pending
|
The two CI failures on external tests are unrelated. |
t8m
approved these changes
Jun 8, 2021
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 9, 2021
…ad othername name constraint' Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #15656)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 9, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #15656)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 9, 2021
…ith key usage keyCertSign also when strict Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #15656)
|
Merged - thanks @t8m |
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
…ad othername name constraint' Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#15656)
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#15656)
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
…ith key usage keyCertSign also when strict Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#15656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
25-test_verify.t:Add test case: accept trusted self-signed EE cert with key usage keyCertSign also when strict.Such a cert would not be well-formed according to RFC 5280, but it is okay because RFC 6818 section 2 clarifies that directly trusted self-signed EE certs are out of scope.
25-test_verify.t:Prevent expiration of test case 'Name constraints bad othername name constraint'as agreed in Check that we got the expected name type when verifying name constraints #15611 (comment). Otherwise the test case would become useless.
test/certs/mkcert.sh:Correct description ofgeneealtparameters