APPS: Fix behavior of print_name() on out==NULL and result type of dump_cert_text()
#16344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDvO
added
the
approval: otc review pending
t8m
reviewed
Aug 23, 2021
t8m
added
branch: master
paulidale
approved these changes
Aug 23, 2021
paulidale
added
approval: done
t8m
approved these changes
Aug 24, 2021
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
|
Merged - thanks. |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 25, 2021
…) on out==NULL Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #16344)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes spurious error queue entries like
mentioned in #16300 (comment).
These are due to the IMHO unfortunate design decison that
BIO_puts(NULL, ...), takes a NULL BIO input as an error,while most/all other BIO print functions simply are no-ops in this case.