Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of ARMv7 and ARM64 CPU features on FreeBSD #17079

Closed
wants to merge 1 commit into from

Conversation

allanjude
Copy link
Contributor

OpenSSL assumes AT_HWCAP = 16 (as on Linux), but on FreeBSD AT_HWCAP = 25

OpenSSL calls elf_auxv_info() with AT_CANARY which returns ENOENT
resulting in all ARM acceleration features being disabled.

CLA: trivial

Checklist

OpenSSL assumes AT_HWCAP = 16 (as on Linux), but on FreeBSD AT_HWCAP = 25

OpenSSL calls elf_auxv_info() with AT_CANARY which returns ENOENT
resulting in all ARM acceleration features being disabled.

CLA: trivial
@allanjude
Copy link
Contributor Author

Would it be preferable to instead do something like:

#ifndef AT_HWCAP
#  define AT_HWCAP 16
#endif

And then use AT_HWCAP to avoid the FreeBSD specific ifdefs?

@t8m
Copy link
Member

t8m commented Nov 19, 2021

Would it be preferable to instead do something like:

#ifndef AT_HWCAP
#  define AT_HWCAP 16
#endif

And then use AT_HWCAP to avoid the FreeBSD specific ifdefs?

Yeah, that would look better to me.

@allanjude
Copy link
Contributor Author

I've opened a different pull request for the alternative version, I agree it is cleaner: #17082

@t8m
Copy link
Member

t8m commented Nov 22, 2021

Closing in favor of #17082

@t8m t8m closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants