Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect arm64-*-*bsd and enable assembly optimizations #17084

Closed
wants to merge 1 commit into from
Closed

Detect arm64-*-*bsd and enable assembly optimizations #17084

wants to merge 1 commit into from

Conversation

allanjude
Copy link
Contributor

CLA: trivial

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Nov 20, 2021
@Sp1l
security/openssl-devel: Fix detection of ARM CPU features
f5164ae 
Upstream:
 * openssl/openssl#17082
 * openssl/openssl#17084

PR:		259937
Submitted by:	allanjude
Differential Revision:	https://reviews.freebsd.org/D33062
@t8m t8m added branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' triaged: feature The issue/pr requests/adds a feature labels Nov 22, 2021
@t8m
Copy link
Member

t8m commented Nov 22, 2021

I am not sure this is acceptable with CLA: trivial. Would you please consider signing a regular CLA? https://www.openssl.org/policies/cla.html

paulidale
paulidale approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Border line on the trivial. A CLA is the best way forwards.
Otherwise it looks good.

@paulidale paulidale added the approval: review pending This pull request needs review by a committer label Nov 24, 2021
@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Nov 24, 2021
@allanjude
Copy link
Contributor Author

I've signed an ICLA

@paulidale paulidale closed this Nov 25, 2021
@paulidale paulidale reopened this Nov 25, 2021
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Nov 25, 2021
@paulidale
Copy link
Contributor

CLA is good.

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer cla: trivial One of the commits is marked as 'CLA: trivial' labels Nov 25, 2021
ocochard pushed a commit to ocochard/freebsd-ports that referenced this pull request Nov 25, 2021
@Sp1l @ocochard
security/openssl-devel: Fix detection of ARM CPU features
4c51b64 
Upstream:
 * openssl/openssl#17082
 * openssl/openssl#17084

PR:		259937
Submitted by:	allanjude
Differential Revision:	https://reviews.freebsd.org/D33062
@paulidale
Copy link
Contributor

Merged to master, thanks for the contribution.

@paulidale paulidale closed this Nov 26, 2021
openssl-machine pushed a commit that referenced this pull request Nov 26, 2021
@allanjude @paulidale
Detect arm64-*-*bsd and enable assembly optimizations
8e22f9d 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17084)
@t8m t8m added the branch: 3.0 Merge to openssl-3.0 branch label May 3, 2022
@t8m
Copy link
Member

t8m commented May 3, 2022

This needs to be cherry-picked to 3.0 when merging #17085 to avoid regression.
@paulidale do you agree?

@t8m t8m reopened this May 3, 2022
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale
Copy link
Contributor

Agreed.

@t8m
Copy link
Member

t8m commented May 5, 2022

Cherry picked to 3.0 branch.

@t8m t8m closed this May 5, 2022
openssl-machine pushed a commit that referenced this pull request May 5, 2022
@allanjude @t8m
Detect arm64-*-*bsd and enable assembly optimizations
9ddab6a 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17084)

(cherry picked from commit 8e22f9d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@allanjude @t8m @paulidale @openssl-machine