Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptodev linux #191

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
8 participants
@nmav
Copy link
Contributor

commented Nov 4, 2014

This pull request corrects issues with the current engine for /dev/crypto.

Also in:
http://rt.openssl.org/Ticket/Display.html?id=2770&user=guest&pass=guest

nmav added some commits Nov 4, 2014

cryptodev: Fix issue with signature generation
That patch also enables support for SHA2 hashes, and
removes support for hashes that were never supported by
cryptodev.
@sreimers

This comment has been minimized.

Copy link

commented Jan 8, 2015

+1

1 similar comment
@henrydcase

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2015

+1

@richsalz

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2016

is this still an issue?

@nmav

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2016

I no longer work with cryptodev. Maybe someone else would take on the patches if he's interested on the issue.

@mattcaswell

This comment has been minimized.

Copy link
Member

commented May 5, 2016

@richsalz. The OP has moved on, and no one else has stepped up to own these patches. They would need some significant work now to bring them up to date with all the latest opacity changes etc. I think we should close this. Do you agree?

@richsalz

This comment has been minimized.

Copy link
Contributor

commented May 5, 2016

Isn’t Ben interested in this? Not saying don't close, but perhaps ask him.

@mattcaswell

This comment has been minimized.

Copy link
Member

commented May 5, 2016

Ping @benlaurie. Your opinion?

@levitte

This comment has been minimized.

Copy link
Member

commented May 6, 2016

I'm interested in this and can take the lead. However, this should be made a post 1.1.0 feature request.

@levitte levitte added this to the Post 1.1.0 milestone May 6, 2016

@levitte levitte added the feature label May 6, 2016

@moonman

This comment has been minimized.

Copy link

commented May 21, 2016

Because of refactoring the patches don't apply with newer version of openssl. I adjusted Nmav's patch and it is available here: https://github.com/archlinuxarm/PKGBUILDs/blob/master/core/openssl-cryptodev/fix_sig-gen_and_allow_copy_evp_contexts.patch

@Voker57

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2016

I also adjusted the patch and improved it by enabling more algorithms and styling the code: https://github.com/Voker57/openssl/tree/cryptodev-patches

@richsalz

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2016

If anyone is interested in submitting a new PR for this, that would be great. Please see the CONTRIBUTING file for CLA etc.

@levitte levitte self-assigned this Oct 27, 2016

for (i = 0; digests[i].id && count < CRYPTO_ALGORITHM_MAX; i++) {
if (digests[i].nid == NID_undef)
continue;
sess.mac = digests[i].id;
sess.mackeylen = digests[i].keylen;
sess.mackeylen = 8;

This comment has been minimized.

Copy link
@levitte

levitte Oct 27, 2016

Member

Hmmm? Shouldn't this be digests[i].digestlen?

EVP_MD_FLAG_ONESHOT,
cryptodev_digest_init,
cryptodev_digest_update,
cryptodev_digest_final,
cryptodev_digest_copy,
cryptodev_digest_cleanup,
EVP_PKEY_NULL_method,
EVP_PKEY_RSA_method,

This comment has been minimized.

Copy link
@levitte

levitte Oct 27, 2016

Member

This is not easily transferable to master at this point. EVP_MD doesn't hold those fields any more, and there are EVP_PKEY methods instead

@levitte levitte referenced this pull request Oct 27, 2016

Closed

Cryptodev linux #1792

1 of 3 tasks complete
@levitte

This comment has been minimized.

Copy link
Member

commented Nov 15, 2016

Closing this, as it became part of #1784 (through #1792)

@levitte levitte closed this Nov 15, 2016

christianpaquin added a commit to christianpaquin/openssl that referenced this pull request Dec 21, 2017

Squashed 'vendor/liboqs/' changes from 04d7eaa..ff3986a
ff3986a removed hard paths (openssl#193)
f62bb02 Enabled and documented building on ARM32 (Raspberry Pi). (openssl#179)
9dab6f6 Flags for configured algorithms generated in config.h (openssl#177)
2d5eb13 Covscan defect fix (openssl#189)
a5b239d Updated README (openssl#191)
d7a72e2 Add checks to verify length of input data for McBits (openssl#186)
cbee5ef Vsoftco issue160 (openssl#188)
581fbbb Initialize out-parameters to NULL (openssl#183)
0d8a354 Properly separate SIDH CLN16 from SIDH CLN16 compressed (openssl#181)
8bc8cd9 Added VisualStudio DLL build configurations (openssl#182)
fc522d6 Embed SIDH IQC REFERENCE parameters (openssl#180)
40ffb4e Updated Windows build (added sig, fixed warnings, 2017 update) (openssl#169)
a329060 Update README.md (openssl#178)
fcbd0f3 KEX memory benchmarks (openssl#171)
b9854b4 Arm compilation (openssl#170)
f3e24e1 Link to algorithm data sheets.
28cc05a Added datasheets for SIDH and Picnic. (openssl#166)

git-subtree-dir: vendor/liboqs
git-subtree-split: ff3986ab9585e521462fb28d24ed024328f609b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.