Remove heartbeats completely #1928
Closed
Conversation
Closed
levitte
changed the title
|
Re-awakening an old PR |
|
This should probably have a CHANGES or NEWS entry. |
Also, Fixes #4856
|
Entries added. Also, it turns out that this fixes #4856, so I added a reference to that issue as well in the squash commit |
|
Merged. 558ea84 Remove heartbeats completely |
|
Why wasn't the configure option moved to the list of deprecated Configure options. Now if someone explicitly compiles with "no-heartbeat" they will get an error rather than it being ignored - which seems to introduce unnecessary breakage. |
| @@ -468,7 +468,6 @@ static const ssl_trace_tbl ssl_exts_tbl[] = { | |||
| {TLSEXT_TYPE_srp, "srp"}, | |||
| {TLSEXT_TYPE_signature_algorithms, "signature_algorithms"}, | |||
| {TLSEXT_TYPE_use_srtp, "use_srtp"}, | |||
| {TLSEXT_TYPE_heartbeat, "tls_heartbeat"}, | |||
FdaSilvaYY
Apr 9, 2019
Contributor
Was it really necessary to remove this trace code ?
Was it really necessary to remove this trace code ?
levitte
Apr 9, 2019
Author
Member
If there's no heartbeat code, what good does that trace do you?
If there's no heartbeat code, what good does that trace do you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Checklist
Description of change