From 4d94d6e60a3e7c1522dee5ab6767cb210069c1a3 Mon Sep 17 00:00:00 2001 From: Pauli Date: Wed, 1 Mar 2023 12:22:49 +1100 Subject: [PATCH 1/2] Coverity 1521557: Error handling issues Check the return from DSA_set0_key and generate an error on failure. Technically a false positive since the function always returns success. --- crypto/dsa/dsa_backend.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/crypto/dsa/dsa_backend.c b/crypto/dsa/dsa_backend.c index 924ccbdc0bad4..30fcc182507be 100644 --- a/crypto/dsa/dsa_backend.c +++ b/crypto/dsa/dsa_backend.c @@ -173,7 +173,10 @@ DSA *ossl_dsa_key_from_pkcs8(const PKCS8_PRIV_KEY_INFO *p8inf, ERR_raise(ERR_LIB_DSA, DSA_R_BN_ERROR); goto dsaerr; } - DSA_set0_key(dsa, dsa_pubkey, dsa_privkey); + if (!DSA_set0_key(dsa, dsa_pubkey, dsa_privkey)) { + ERR_raise(ERR_LIB_DSA, ERR_R_BN_LIB); + goto dsaerr; + } goto done; From 903c6954748efe59456605ee31a93a69bf031a12 Mon Sep 17 00:00:00 2001 From: Pauli Date: Wed, 1 Mar 2023 12:35:36 +1100 Subject: [PATCH 2/2] fixup! Coverity 1521557: Error handling issues --- crypto/dsa/dsa_backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/dsa/dsa_backend.c b/crypto/dsa/dsa_backend.c index 30fcc182507be..ceaf6e6877f36 100644 --- a/crypto/dsa/dsa_backend.c +++ b/crypto/dsa/dsa_backend.c @@ -174,7 +174,7 @@ DSA *ossl_dsa_key_from_pkcs8(const PKCS8_PRIV_KEY_INFO *p8inf, goto dsaerr; } if (!DSA_set0_key(dsa, dsa_pubkey, dsa_privkey)) { - ERR_raise(ERR_LIB_DSA, ERR_R_BN_LIB); + ERR_raise(ERR_LIB_DSA, ERR_R_INTERNAL_ERROR); goto dsaerr; }