Mention ENGINE removal in CHANGES and NEWS #29138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
added
approval: review pending
t8m
requested changes
Nov 13, 2025
CHANGES.md
Outdated
|
|
||
| *Ryan Hooper* | ||
|
|
||
| * The ENGINE feature was removed. |
Member
There was a problem hiding this comment.
Maybe at least add here (not in NEWS) that OPENSSL_NO_ENGINE is always defined.
mattcaswell
reviewed
Nov 13, 2025
CHANGES.md
Outdated
|
|
||
| *Ryan Hooper* | ||
|
|
||
| * The ENGINE feature was removed. |
Member
There was a problem hiding this comment.
I think this deserves a bigger entry than just this. We should describe the fact that all ENGINE_* APIs have been removed as a result. We should tell users what they should do about it (transition to providers, change their application to not call ENGINE_* APIs any more, or possibly use the stubs if necessary).
jogme
force-pushed
the
engine_removal_changelog
branch
from
4d6a6e9 to
8110dec
Compare
paulidale
reviewed
Nov 13, 2025
CHANGES.md
Outdated
Comment on lines
49
to
53
| * Removed ENGINE feature. `OPENSSL_NO_ENGINE` will always be defined. | ||
| `ENGINE_` prefixed functions should be removed from any source code. | ||
| When it is not possible right away, the macro `OPENSSL_ENGINE_STUB` | ||
| might be used to silence compilation errors, but it will leave the user | ||
| with broken ENGINE usage if any. Use provider API instead of ENGINEs. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Removed ENGINE feature. `OPENSSL_NO_ENGINE` will always be defined. | |
| `ENGINE_` prefixed functions should be removed from any source code. | |
| When it is not possible right away, the macro `OPENSSL_ENGINE_STUB` | |
| might be used to silence compilation errors, but it will leave the user | |
| with broken ENGINE usage if any. Use provider API instead of ENGINEs. | |
| * Removed engines. The `no-engine` option is always present when configuring and | |
| * the `OPENSSL_NO_ENGINE` define is always set when building. | |
| All `ENGINE_` prefixed functions have also been removed from the source code. | |
| Provider APIs should be used to provide functionality similar to what engines used to. |
This part
When it is not possible right away, the macro
OPENSSL_ENGINE_STUB
might be used to silence compilation errors, but it will leave the user
with broken ENGINE usage if any.
Should be modified to past tense and added when it is done.
Member
There was a problem hiding this comment.
This part
When it is not possible right away, the macro
OPENSSL_ENGINE_STUB
might be used to silence compilation errors, but it will leave the user
with broken ENGINE usage if any.Should be modified to past tense and added when it is done.
It is already done. This is an instruction to user.
Suggested change
| * Removed ENGINE feature. `OPENSSL_NO_ENGINE` will always be defined. | |
| `ENGINE_` prefixed functions should be removed from any source code. | |
| When it is not possible right away, the macro `OPENSSL_ENGINE_STUB` | |
| might be used to silence compilation errors, but it will leave the user | |
| with broken ENGINE usage if any. Use provider API instead of ENGINEs. | |
| * ENGINE support was removed. The `no-engine` build option and the | |
| `OPENSSL_NO_ENGINE` macro is always present. | |
| Applications using `ENGINE_` functions that do not check the presence | |
| of `OPENSSL_NO_ENGINE` can be built by defining a macro | |
| `OPENSSL_ENGINE_STUBS`, however all these functions will return error | |
| if called. Provider API needs to be used to replace engines functionality. |
Contributor
Author
There was a problem hiding this comment.
Note that this is going to the feature branch
Contributor
Author
There was a problem hiding this comment.
I reworded your suggestion a little. PTAL
t8m
reviewed
Nov 14, 2025
Resolves: openssl/project#1423 Signed-off-by: Norbert Pocs <norbertp@openssl.org>
jogme
force-pushed
the
engine_removal_changelog
branch
from
be04fe7 to
ff1081b
Compare
t8m
approved these changes
Nov 14, 2025
InfoHunter
approved these changes
Nov 17, 2025
jogme
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Member
|
Merged to the feature branch. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 19, 2025
Resolves: openssl/project#1423 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Paul Yang <paulyang.inf@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #29138)
Sashan
pushed a commit
to jogme/openssl
that referenced
this pull request
Nov 30, 2025
Resolves: openssl/project#1423 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Paul Yang <paulyang.inf@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#29138)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 1, 2025
Resolves: openssl/project#1423 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Paul Yang <paulyang.inf@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#29138)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 1, 2025
Resolves: openssl/project#1423 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Paul Yang <paulyang.inf@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#29138)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 1, 2025
Resolves: openssl/project#1423 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Paul Yang <paulyang.inf@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#29138)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1423 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Paul Yang <paulyang.inf@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#29138)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1423 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Paul Yang <paulyang.inf@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#29138)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1423 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Paul Yang <paulyang.inf@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#29138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: openssl/project#1423
Checklist