Test server side session caching #4072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulidale
approved these changes
Aug 2, 2017
paulidale
added
the
approval: done
In particular this covers the scenario mentioned in openssl#4014
mattcaswell
force-pushed
the
test-server-sess-cache
branch
from
a033d1d
to
9f506d7
Compare
mattcaswell
changed the title
|
I've rebased and |
|
The code looks good too. Not sure about the Travis failure though. |
levitte
pushed a commit
that referenced
this pull request
Aug 9, 2017
Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #4072)
|
Merged |
paulidale
removed
the
approval: done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had tests for session caching but they only covered the client side (!!) not server side. This adds some server side caching tests. In particular it tests the scenario mentioned in #4014.
As part of this work I needed to duplicate a session object. We don't have a public API for that (although we have an internal one). This missing API was mentioned somewhere else recently (by @kroeckx I think), so I've added it as part of this PR.
I also fixed some bugs in sslapitest introduced recently by commit 7e885b7.
Note this should not be merged until #4014 is. The tests will fail (including CI) until then. Hence marked as WIP. For master only. The issue described in #4014 is present in 1.1.0 too, but it's non-trivial to backport this.
Checklist