Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move randomness to allocated buffer #4226

Closed
wants to merge 1 commit into from
Closed

Move randomness to allocated buffer #4226

wants to merge 1 commit into from

Conversation

richsalz
Copy link
Contributor

Don't keep it in the DRBG object, just allocate/free as needed.

Move randomness to allocated buffer
6ab6a05 
Don't keep it in the DRBG object, just allocate/free as needed.
@richsalz richsalz added branch: master Merge to master branch approval: done This pull request has the required number of approvals labels Aug 22, 2017
@richsalz richsalz self-assigned this Aug 22, 2017
paulidale
paulidale approved these changes Aug 23, 2017
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing the lifetime of the seed material is a nice improvement.

levitte pushed a commit that referenced this pull request Aug 23, 2017
Move randomness to allocated buffer
9d951a7 
Don't keep it in the DRBG object, just allocate/free as needed.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #4226)
@richsalz
Copy link
Contributor Author

Thanks!

@richsalz richsalz closed this Aug 23, 2017
@richsalz richsalz deleted the dynamic-entropy-buffer branch August 23, 2017 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulidale paulidale paulidale approved these changes

Assignees

@richsalz richsalz

Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richsalz @paulidale