Only reset the ctx when a cipher is given #4613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the 1.0.2 behaviour
richsalz
approved these changes
Oct 29, 2017
| @@ -50,7 +50,8 @@ void EVP_CIPHER_CTX_free(EVP_CIPHER_CTX *ctx) | |||
| int EVP_CipherInit(EVP_CIPHER_CTX *ctx, const EVP_CIPHER *cipher, | |||
| const unsigned char *key, const unsigned char *iv, int enc) | |||
| { | |||
| EVP_CIPHER_CTX_reset(ctx); | |||
| if (cipher) | |||
There was a problem hiding this comment.
Please put explicit NULL comparision.
|
This is for 1.1.0 and master? |
levitte
pushed a commit
that referenced
this pull request
Oct 30, 2017
This restores the 1.0.2 behaviour Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Benjamin Kaduk <bkaduk@akamai.com> GH: #4613
|
Fixed in master an 1.1.0 |
djmdjm
added a commit
to openssh/openssh-portable
that referenced
this pull request
Oct 17, 2018
Previous versions have a bug with EVP_CipherInit() when passed a NULL EVP_CIPHER, per openssl/openssl#4613 ok dtucker@
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This restores the 1.0.2 behaviour
This was pointed out by @davidben in openssh/openssh-portable#48 (comment)