New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we send an alert on error when processing a ticket #6852

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@mattcaswell
Copy link
Member

mattcaswell commented Aug 3, 2018

In some scenarios the connection could fail without an alert being sent.
This causes a later assertion failure.

Thanks to Quarkslab for reporting this.

Ensure we send an alert on error when processing a ticket
In some scenarios the connection could fail without an alert being sent.
This causes a later assertion failure.

Thanks to Quarkslab for reporting this.
@dot-asm

dot-asm approved these changes Aug 3, 2018

@richsalz richsalz added the ready label Aug 3, 2018

@kaduk

kaduk approved these changes Aug 6, 2018

Copy link
Contributor

kaduk left a comment

Do we need to do a pass over the state machine code for other potential instances of similar issues when a subroutine is used that calls SSLfatal on error?

@mattcaswell

This comment has been minimized.

Copy link
Member Author

mattcaswell commented Aug 6, 2018

Do we need to do a pass over the state machine code for other potential instances of similar issues when a subroutine is used that calls SSLfatal on error?

I did a global search for "already called" in the "ssl" directory and reviewed every instance of this. I found one of case of this class of error. Fix in #6872.

@mattcaswell

This comment has been minimized.

Copy link
Member Author

mattcaswell commented Aug 6, 2018

Pushed. Thanks.

@mattcaswell mattcaswell closed this Aug 6, 2018

levitte pushed a commit that referenced this pull request Aug 6, 2018

Ensure we send an alert on error when processing a ticket
In some scenarios the connection could fail without an alert being sent.
This causes a later assertion failure.

Thanks to Quarkslab for reporting this.

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from #6852)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment