New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure: warn when 'none' is the chosen seed source #6981

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@levitte
Member

levitte commented Aug 16, 2018

Fixes #6980

Configure Outdated
die "Cannot seed with none and anything else" if scalar(@seed_sources) > 1;
warn <<_____ if scalar(@seed_sources) == 1;
You have selected NO seed source. Some functions (such as creating keys)
will not work.

This comment has been minimized.

@mattcaswell

mattcaswell Aug 16, 2018

Member

Well they won't work without manual seeding. Perhaps a pointer towards the RAND_DRBG(7) page?

This comment has been minimized.

@mspncp

mspncp Aug 16, 2018

Contributor

My humble suggestion:

You have selected the --with-rand-seed=none option, which effectively disables
automatic reseeding of the OpenSSL random generator. All operations depending on
the random generator such as creating keys will not work unless the random generator
is seeded manually by the application.

Please read the 'Note on random number generation' section in the INSTALL instructions 
document and the RAND_DRBG(7) manual page for more details.

This comment has been minimized.

@mspncp

mspncp Aug 16, 2018

Contributor

correction: instructions document

@mspncp

mspncp approved these changes Aug 16, 2018

LGTM

@levitte

This comment has been minimized.

Member

levitte commented Aug 16, 2018

Merged.

2805ee1 Configure: warn when 'none' is the chosen seed source

@levitte levitte closed this Aug 16, 2018

levitte added a commit that referenced this pull request Aug 16, 2018

Configure: warn when 'none' is the chosen seed source
Fixes #6980

Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
(Merged from #6981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment