New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check some SRP return values #8019

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mattcaswell
Copy link
Member

mattcaswell commented Jan 14, 2019

The first commit fixes a missing return value spotted by the OSTIF audit.

The second commit fixes a number of other missing return checks in the SRP code.

@paulidale paulidale added the ready label Jan 14, 2019

@paulidale

This comment has been minimized.

Copy link
Contributor

paulidale commented Jan 15, 2019

The Travis failure is not relevant.

levitte pushed a commit that referenced this pull request Jan 15, 2019

Check a return value in the SRP code
Spotted by OSTIF audit

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #8019)

(cherry picked from commit 0a5bda6)

levitte pushed a commit that referenced this pull request Jan 15, 2019

Check more return values in the SRP code
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #8019)

(cherry picked from commit d63bde7)
@mattcaswell

This comment has been minimized.

Copy link
Member Author

mattcaswell commented Jan 15, 2019

Pushed. Thanks.

levitte pushed a commit that referenced this pull request Jan 15, 2019

Check a return value in the SRP code
Spotted by OSTIF audit

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #8019)

levitte pushed a commit that referenced this pull request Jan 15, 2019

Check more return values in the SRP code
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #8019)

makr added a commit to makr/openssl that referenced this pull request Jan 18, 2019

Check a return value in the SRP code
Spotted by OSTIF audit

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from openssl#8019)

(cherry picked from commit 0a5bda6)

makr added a commit to makr/openssl that referenced this pull request Jan 18, 2019

Check more return values in the SRP code
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from openssl#8019)

(cherry picked from commit d63bde7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment