Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMS_verify.pod #8952

Closed
wants to merge 3 commits into from
Closed

Update CMS_verify.pod #8952

wants to merge 3 commits into from

Conversation

sambitdash
Copy link
Contributor

@sambitdash sambitdash commented May 19, 2019 •
edited

Minor typo fixed

Checklist
  • documentation is added or updated

CLA: trivial

@sambitdash
Update CMS_verify.pod
0a2426a 
Minor typo fixed
@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label May 19, 2019
@slontis
Copy link
Member

slontis commented May 21, 2019

Hello Sambit,
In order to pass the trivial CLA test run:

git commit --amend
and update the commit message by putting
"CLA: trivial" on a line by itself in your commit message body.

@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label May 21, 2019
@slontis
Copy link
Member

slontis commented May 22, 2019

@ping

levitte
levitte approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is trivial

@levitte levitte added branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch branch: master Merge to master branch approval: done This pull request has the required number of approvals labels May 23, 2019
@levitte
Copy link
Member

levitte commented May 23, 2019

(note that I labeled this for both master and 1.1.1)

levitte pushed a commit that referenced this pull request May 24, 2019
@sambitdash @slontis
Doc update: minor typo in CMS_verify.pod
55e09d1 
CLA: trivial

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #8952)
levitte pushed a commit that referenced this pull request May 24, 2019
@sambitdash @slontis
Doc update: minor typo in CMS_verify.pod
6b26134 
CLA: trivial

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #8952)

(cherry picked from commit 55e09d1)
@slontis slontis closed this May 24, 2019
@sambitdash sambitdash deleted the patch-2 branch May 25, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sambitdash @slontis @levitte @openssl-machine