Join GitHub today
Change provider params from int to size_t #9699
levitte left a comment
A whole bunch of nits. All of them are not so much about what types are compatible with each other, but what we express in code. Do we use size_t just to get an unsigned integer of a certain size, or to express that this value is intended to be used as a size? And while I'm at it, what's wrong with using bit fields for individual flags?
Ok, looks generally good... I have one last thing [+] for your consideration: is
[+] [ahem] the "last thing" is porentially "the thing before the last thing", I hope we're clear on that