Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CRMF symmetric key handling #9774

Closed
wants to merge 5 commits into from
Closed

Conversation

@Akretsch
Copy link
Contributor

Akretsch commented Sep 5, 2019

Fixes related to review comments #7646 (comment) , #7646 (comment) , #7646 (comment) given by @bernd-edlinger

crypto/crmf/crmf_lib.c Outdated Show resolved Hide resolved
@Akretsch Akretsch force-pushed the Akretsch:crmf_fix branch from 6d3b073 to 20c7d1e Sep 5, 2019
@Akretsch Akretsch force-pushed the Akretsch:crmf_fix branch from 20c7d1e to eec433c Sep 5, 2019
crypto/crmf/crmf_lib.c Outdated Show resolved Hide resolved
@Akretsch Akretsch force-pushed the Akretsch:crmf_fix branch from 56b9674 to 6d73c42 Sep 6, 2019
crypto/crmf/crmf_lib.c Outdated Show resolved Hide resolved
crypto/crmf/crmf_lib.c Outdated Show resolved Hide resolved
crypto/crmf/crmf_lib.c Outdated Show resolved Hide resolved
crypto/crmf/crmf_lib.c Outdated Show resolved Hide resolved
@Akretsch

This comment has been minimized.

Copy link
Contributor Author

Akretsch commented Sep 9, 2019

Thanks for help and guidance! Do I need a second reviewer for this PR?

@bernd-edlinger

This comment has been minimized.

Copy link
Member

bernd-edlinger commented Sep 9, 2019

correct.

@Akretsch

This comment has been minimized.

Copy link
Contributor Author

Akretsch commented Sep 10, 2019

@mattcaswell May I ask you for 2nd review of this PR to drive our #9107 a little bit forward?

@mattcaswell

This comment has been minimized.

Copy link
Member

mattcaswell commented Sep 14, 2019

Pushed. Thanks.

levitte pushed a commit that referenced this pull request Sep 14, 2019
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #9774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.