Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential memory leaks with BN_to_ASN1_INTEGER #9833

Closed
wants to merge 1 commit into from

Conversation

@bernd-edlinger
Copy link
Member

bernd-edlinger commented Sep 9, 2019

This is a potential memory leak, does unfortunately not cherry-pick.

paulidale added a commit to paulidale/openssl that referenced this pull request Sep 10, 2019
Corresponding to openssl#9833 but for some of the EC code.
OpenSSL never calls the parent function in a way where this is possible
(the params argument is always NULL) but third parties could and OpenSSL
might in the future.
@mattcaswell

This comment has been minimized.

Copy link
Member

mattcaswell commented Sep 10, 2019

Is this intended for the release?

@bernd-edlinger

This comment has been minimized.

Copy link
Member Author

bernd-edlinger commented Sep 10, 2019

would be good, yes.

@mattcaswell

This comment has been minimized.

Copy link
Member

mattcaswell commented Sep 10, 2019

Looks like this issue has been there a long while. I'd rather not pull in new PRs into the release without a good justification, so I'd prefer to wait until the repo is unfrozen for this one.

@bernd-edlinger

This comment has been minimized.

Copy link
Member Author

bernd-edlinger commented Sep 10, 2019

okay, agreed.

@paulidale

This comment has been minimized.

Copy link
Contributor

paulidale commented Sep 10, 2019

Agreed, not for the upcoming release.

levitte pushed a commit that referenced this pull request Sep 13, 2019
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #9833)
levitte pushed a commit that referenced this pull request Sep 13, 2019
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #9833)

(cherry picked from commit f28bc7d)
@bernd-edlinger

This comment has been minimized.

Copy link
Member Author

bernd-edlinger commented Sep 13, 2019

Merged to master as f28bc7d, and 1.1.1 as 515c728. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.