Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct printing of some otherName variants #9965

Closed
wants to merge 5 commits into from

Conversation

@beldmit
Copy link
Member

beldmit commented Sep 21, 2019

Fixes #9950
Fixes #9951

Implementing printing out of some otherName variants:
xmppAddr
srvName
SmtpUTF8Mailbox (partially interferes with #9654).

Checklist
  • documentation is added or updated
  • tests are added or updated
@dcooper16

This comment has been minimized.

Copy link
Contributor

dcooper16 commented Sep 23, 2019

May I suggest adding the Microsoft Universal Principal Name to the list of otherName types that can be printed? The OID is already recognized by OpenSSL (SN_ms_upn, LN_ms_upn, NID_ms_upn, OBJ_ms_upn, etc. are already defined). The UPN is encoded as a UTF8String.

@beldmit

This comment has been minimized.

Copy link
Member Author

beldmit commented Sep 23, 2019

Not a problem, but not just now.

@beldmit

This comment has been minimized.

Copy link
Member Author

beldmit commented Sep 23, 2019

Done

@beldmit

This comment has been minimized.

Copy link
Member Author

beldmit commented Sep 24, 2019

Would it be better to squash all the commits in one or leave as is?

@paulidale

This comment has been minimized.

Copy link
Contributor

paulidale commented Sep 24, 2019

Squashing is generally better.

For the record: I approve a squashed version unseen.

levitte pushed a commit that referenced this pull request Sep 24, 2019
The supported variants are
- SmtpUTF8Name
- xmppAddr
- MS UPN
- SRVName

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #9965)
@beldmit

This comment has been minimized.

Copy link
Member Author

beldmit commented Sep 24, 2019

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.