Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.1.1 to manual sidebar #100

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@mspncp
Copy link
Contributor

commented Dec 27, 2018

No description provided.

@mspncp mspncp force-pushed the mspncp:pr-fix-mansidebar branch from a12c93a to d872861 Dec 27, 2018

@mattcaswell

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Needs a second OMC review

@t-j-h

t-j-h approved these changes Jan 2, 2019

@t-j-h t-j-h added the ready label Jan 2, 2019

levitte pushed a commit that referenced this pull request Jan 2, 2019

Add 1.1.1 to manual sidebar
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #100)
@mattcaswell

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Pushed. Thanks.

@mattcaswell mattcaswell closed this Jan 2, 2019

@mspncp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2019

Matt, did this go online already? Strangely, the sidebar for 1.1.0 now shows all manual versions, while the sidebars for master, 1.1.1 and 1.0.2 are still missing the link to version 1.1.1.

@mattcaswell

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Yes, it went online. I just purged the CDN cache manually which seems to have fixed some pages but not others. I suspect an issue in our purging script. Perhaps @levitte has an idea.

@levitte

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

The docs directory is ignored by the purge-one-hour script, 'cause the purge program it uses gets overwhelmed by too many files, and simply didn't work with directories, at least a year ago, and I have frankly not looked at that since...

However, I just tried a simple trigger of docs/manmaster/index.html, to no avail... so it seems to me the issues lies with the CDN, unless I'm doing something very wrong...

@mattcaswell

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

This URL is fine:

https://www.openssl.org/docs/manmaster/index.html

But this one is not:

https://www.openssl.org/docs/manmaster

So it seems to be URLs which don't include an explicit ".html"

@levitte

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Oh ok, so the mechanism supports directories now... separately.

@mattcaswell

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

@levitte

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Hmmm, the purging script doesn't go into other docs trees than manmaster, wonder why...

@levitte

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Ah, because -mtime -2. I can add a control to force all files to be invalidated.

@levitte

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Oh, no, it's because the script only look at included .inc files, not .shtml ones...

@richsalz

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2019

Only actual files, not directories which get auto-indexed.

@levitte

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Okie

@levitte

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Either way, I've done quite a bit of fixing of the main purging script, it's become better at detecting the .html files that are affected by diverse changes (including in inc/).

[going back to vacationing]

@mattcaswell

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Seems to be working now. Thanks @levitte.

@mspncp mspncp deleted the mspncp:pr-fix-mansidebar branch Jan 2, 2019

@mspncp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2019

Thanks from me, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.