From 1b2b0b83289acd0dcc968631a2bc5e0f3b31b43c Mon Sep 17 00:00:00 2001 From: David Moreau-Simard Date: Fri, 29 Jul 2016 14:12:14 -0400 Subject: [PATCH] Explicitely pass RSYNC_PASSWORD when uploading logs to ci.c.o artifacts The rdo-jenkins.ci.centos.org jenkins slave has an implicit export of RSYNC_PASSWORD located in .bash_profile which is sourced when spawning a new shell. However, this variable is already available and configured on the jenkins slave (in the ci.c.o web interface). When setting up and testing new slaves without that .bash_profile export, the RSYNC_PASSWORD variable was not available in that context. The RSYNC_PASSWORD variable is available on the machine running Ansible, the jenkins slave, but not the duffy node. We noticed the issue when weirdo jobs would be able to upload artifacts while the quickstart jobs failed. Change-Id: I6aababdf48fe8a5b19acaecb1b8427a68591973f --- tasks/main.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tasks/main.yml b/tasks/main.yml index a44a76b6c..f3c7ece88 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -186,7 +186,9 @@ when: artcl_rsync_logs|bool and artcl_rsync_use_daemon == false #centos-ci - - name: upload to the artifact server using pubkey auth + - name: upload to the artifact server using password auth + environment: + RSYNC_PASSWORD: "{{ lookup('env', 'RSYNC_PASSWORD') }}" shell: > rsync -av {{ artcl_collect_dir }}/ {{ artcl_rsync_path }}/$BUILD_TAG retries: 5