/charm-layer-openstack

WIP HA config (Do not merge) #4

Open
wants to merge 7 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gnuoy @ajkavanagh
@gnuoy
Collaborator

gnuoy commented May 11, 2016

WIP to ease configure HA resources. PR created to facilitate discussion, please do not merge yet.
lib/charm/openstack/ha.py
+ vip,
+ nic=iface,
+ cidr=netmask
+ )
@ajkavanagh

ajkavanagh May 11, 2016

Contributor

Minor style point, but generally it's prefered to not have 'dangling' braces. e.g. cidr=netmask,))

gnuoy pushed a commit to gnuoy/charm-layer-openstack that referenced this pull request Jul 27, 2016

@javacruft
Merge pull request #4 from gnuoy/bug/issue_3 
Correct adapters_instance call from render_configs
4354fd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment