Permalink
Browse files

Metadata Compare breaks under special conditions

When comparing OSP10 to OSP13 we were seeing issues when comparing
metadata. This patch addresses that issue, as well as ignores IP
addresses for the compare.

Change-Id: I9b827c80d98d84c862a228e72c2e6e3ee6cb4d9a
  • Loading branch information...
jtaleric authored and aakarshgopi committed Jan 4, 2019
1 parent fcd0d7e commit cc9295342df390de652ce5671f306ca67c4254d7
Showing with 6 additions and 4 deletions.
  1. +6 −4 browbeat/elastic.py
@@ -163,10 +163,10 @@ def get_software_metadata(self, index, role, browbeat_uuid):
for result in results:
for metadata in result['_source']['software-metadata']:
for service in metadata:
if pattern.match(metadata[service]['node_name']):
if metadata[service]['node_name'] not in nodes:
nodes[metadata[service][
'node_name']] = metadata
if 'node_name' in metadata[service]:
if pattern.match(metadata[service]['node_name']):
if metadata[service]['node_name'] not in nodes:
nodes[metadata[service]['node_name']] = metadata
return nodes
else:
self.logger.error("UUID {} wasn't found".format(browbeat_uuid))
@@ -535,6 +535,8 @@ def compare_metadata(self, index, role, uuids):
ignore = [
"connection",
"admin_url",
"my_ip",
"local_ip",
"bind_host",
"rabbit_hosts",
"auth_url",

0 comments on commit cc92953

Please sign in to comment.