Browse files

glance-control need not locate a server's config file (lp#919520)

Before converting to cfg, glance-control would use find_config_file() to
locate the servers config file if the user did not explicitly specify

With the change over to cfg, we screwed that code up. However, we should
instead just allow the server to locate its own config file rather than
trying to guess what it will use.

Change-Id: I422839ae4c684ff2de3a0a96dd54c6b74ce6df97
  • Loading branch information...
markmc committed Jan 23, 2012
1 parent 8d83124 commit 3b2ef8e29e21ce1c00c33de8f3521b3c7cf8d241
Showing with 12 additions and 12 deletions.
  1. +12 −12 bin/glance-control
@@ -111,8 +111,13 @@ def do_start(server, conf, args):
fp.write('%d\n' % pid)
def launch(ini_file, pid_file):
print 'Starting %s with %s' % (server, ini_file)
def launch(pid_file, conf_file=None):
args = [server]
print 'Starting %s' % server,
if conf_file:
args += ['--config-file', conf_file]
print 'with %s' % conf_file,
pid = os.fork()
if pid == 0:
@@ -124,7 +129,7 @@ def do_start(server, conf, args):
except OSError:
os.execlp('%s' % server, server, '--config-file', ini_file)
os.execlp('%s' % server, *args)
except OSError, e:
sys.exit('unable to launch %s. Got error: %s'
% (server, "%s" % e))
@@ -137,16 +142,11 @@ def do_start(server, conf, args):
pid_file = os.path.abspath(conf.pid_file)
if args and os.path.exists(args[0]):
conf_file = os.path.abspath(os.path.expanduser(args[0]))
# Assume paste config is in the last config file
conf_file = conf.config_file[-1]
except RuntimeError, err:
sys.exit("Could not find any configuration file to use: %s" % err)
conf_file = None
if args and os.path.exists(args[0]):
conf_file = os.path.abspath(os.path.expanduser(args[0]))
launch(conf_file, pid_file)
launch(pid_file, conf_file)
def do_stop(server, conf, args, graceful=False):

0 comments on commit 3b2ef8e

Please sign in to comment.