Permalink
Commits on Jul 17, 2018
Commits on Jul 16, 2018
  1. Use glance.context.RequestContext in tests

    lbragstad committed Jul 16, 2018
    There were some recent changes to oslo.policy that include specific
    type checks of the ``creds`` parameter passed to the ``enforce()``
    method:
    
      https://review.openstack.org/#/c/578995/
    
    The above change allows consuming projects to pass instances
    of oslo_context.context.RequestContext to the policy enforcer, as
    opposed to building a dictionary instance from scratch multiple
    different ways across projects.
    
    The glance unit tests were failing with the new version of
    oslo.policy (1.38.0) because they were passing in a Mock instance
    which failed the new, more strict, type check.
    
    This commit converts the setUp class of the tests to use an instance
    of glance.context.RequestContext, which subclasses RequestContext
    from oslo.context. It also sets the user_id and project_id attributes
    of the context object to override authorization checks.
    
    This should allow glance to pass with newer versions of oslo.policy.
    
    Change-Id: I0a69bc9565d57fd6ad8484abc5fce0e8dd45f9f2
    Closes-Bug: 1781976
Commits on Jul 13, 2018
  1. Update glance documentation for trait support

    arvindn05 committed Jul 12, 2018
    Required traits on the image allow specifying a server to be
    built only on compute nodes which express those traits. The
    Nova Scheduler has been updated to look at the image trait
    properties when selecting compute nodes.
    
    Updating the documentation for glance to explain the same.
    
    Documentation is similar to flavor required traits documentation available
    here: https://docs.openstack.org/nova/latest/user/flavors.html#extra-specs
    
    Change-Id: I716821abf44238eecc9c4a1d198d8a31b87dedce
    Implements: blueprint glance-image-traits
Commits on Jul 10, 2018
  1. fix tox python3 overrides

    dhellmann authored and nguyentrihai93 committed Jun 6, 2018
    We want to default to running all tox environments under python 3, so
    set the basepython value in each environment.
    
    We do not want to specify a minor version number, because we do not
    want to have to update the file every time we upgrade python.
    
    We do not want to set the override once in testenv, because that
    breaks the more specific versions used in default environments like
    py35 and py36.
    
    Change-Id: Ic9645685e0f9ae25b0b2b754b11e34d8aef41829
    Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Commits on Jul 9, 2018
  1. replace cmp with total_ordering decorator

    dhellmann authored and nguyentrihai93 committed Jun 6, 2018
    The cmp() built-in is no longer available under python 3 and the
    __cmp__ method is not used. Remove __cmp__ and __ne__ and add a __lt__
    method and use the functools.total_ordering decorator to provide all
    of the rich comparison methods for StoreLocations.
    
    Change-Id: Iae1d0c27bd82a42c80fc98f87c9b85edef527c51
    Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Commits on Jul 6, 2018
  1. Merge "Documentation for OSSN-0075 mitigation"

    Zuul authored and openstack-gerrit committed Jul 6, 2018
  2. Documentation for OSSN-0075 mitigation

    ostackbrian committed Jul 5, 2018
    Updates the Glance Administration Guide and adds a release note.
    
    Depends-on: https://review.openstack.org/#/c/579507/
    Change-Id: I87343b67614da8dea3a09b10456f4bfc0042ed0e
  3. Change default age of purge_images_table to 180

    Erno Kuvaja
    Erno Kuvaja committed Jul 6, 2018
    The `glance manage purge-images-table` is supposed to be used
    only if really required due to OSSN-0075. And the advice is
    not to purge any freshly deleted rows due to the possible
    ID collision of still in use images. This change increases
    the default of "age_in_days" to 180 from it's original 30 to
    stress this out. User can still define smaller age if they
    must.
    
    Change-Id: Idb13288b72b31940a357fc9b11db2d6bcd396261
  4. Merge "Mitigate OSSN-0075"

    Zuul authored and openstack-gerrit committed Jul 6, 2018
Commits on Jul 5, 2018
  1. Mitigate OSSN-0075

    Abhishek Kekane
    Abhishek Kekane committed Jul 2, 2018
    Modified the current ``glance-manage db purge`` command to eliminate images
    table from purging the records. Added new command
    ``glance-manage db purge_images_table`` to purge the records from images
    table.
    
    DocImpact
    SecurityImpact
    
    Change-Id: Ie6641659b54543ed9f96c393d664e52a26bfaf6a
    Implements: blueprint mitigate-ossn-0075
Commits on Jul 2, 2018
  1. Prevent taskflow creation in impossible import

    Erno Kuvaja Abhishek Kekane
    Erno Kuvaja and Abhishek Kekane committed Mar 28, 2018
    This change prevents taskflow creation during image import in cases
    we know for sure that the image activation won't be successful.
    
    The change follows the Glance principles of failing early and tries
    to provide as meaningful error messages to the end user as possible.
    
    Co-authored-by: Abhishek Kekane <akekane@redhat.com>
    Closes-bug: 1758943
    Change-Id: Iaee2781d07f4c0afd4f886f0b30b523bd47f1058
  2. useful-image-properties.rst: Update default RNG source

    kashyapc committed Jul 2, 2018
    Nova's libvirt driver has changed[*] the default source from /dev/random
    to /dev/urandom:
    
        "Since libvirt 1.3.4, any RNG (Random Number Generator) device path
        (that returns random numbers when read!) is accepted. However, the
        recommended source of entropy is `/dev/urandom` (it is non-blocking;
        and doesn't have the same limitations of `dev/random`, which is a
        legacy interface)."
    
    Update the relevant Glance documentation to reflect that.
    
    [*] https://git.openstack.org/cgit/openstack/nova/commit/?id=814bfd93
    
    Change-Id: I656b5c244b98202f3c8d019d0bbeddc4e7c0314a
    Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
Commits on Jun 20, 2018
Commits on Jun 19, 2018
  1. Merge "Convert to string before using assertIn"

    Zuul authored and openstack-gerrit committed Jun 19, 2018
Commits on Jun 14, 2018
Commits on Jun 12, 2018
  1. Merge "Add image conversion plugin"

    Zuul authored and openstack-gerrit committed Jun 12, 2018
Commits on Jun 11, 2018
  1. Add image conversion plugin

    Erno Kuvaja
    Erno Kuvaja committed Jun 5, 2018
    This change adds image conversion plugin for Interoperable
    Image Import workflow.
    
    Change-Id: Icd4f4f30b12f6dd073dcdbf7f842e933c75ae249
Commits on Jun 7, 2018
  1. Merge "Regenerate sample config files"

    Zuul authored and openstack-gerrit committed Jun 7, 2018
  2. Regenerate sample config files

    ostackbrian committed Jun 7, 2018
    Regenerate the config files for Rocky-2 milestone release.
    
    Change-Id: I4d008daacd500ffcc8c0551ae085af854828b8c1
  3. Update Release CPL doc about periodic jobs

    ostackbrian committed Jun 5, 2018
    At the weekly Glance meeting on 2018-05-17 it was agreed that the
    Release CPL will monitor the periodic "tips" test jobs and report
    on their status at the weekly meeting.  This patch updates the
    appropriate section of the Glance Contributor's Guide.
    
    Change-Id: Ieeab3e3a42b8197f8b0544e97748ffdb8f620f13
  4. Use group_regex to serialize scrubber tests

    zaneb committed May 30, 2018
    Instead of doing two separate test runs, use the group_regex option to
    stestr to group tests that cannot be run in parallel into the same
    worker.
    
    Change-Id: I3d69d5c72d69484f4e1c9c0b11122d0cf3703d60
    Related-Bug: #1768077
  5. Merge "Refactor exception handling in cmd.api"

    Zuul authored and openstack-gerrit committed Jun 7, 2018
  6. Replace Chinese punctuation with English punctuation

    inspurericzhang committed May 21, 2018
    Curly quotes(Chinese punctuation) usually input from Chinese input method.
    When read from english context, it makes some confusion.
    
    Change-Id: I9b8830179fb98f3a6bef479bbaa12df70311269a
  7. Remove deprecated 'enable_image_import' option

    Erno Kuvaja
    Erno Kuvaja committed Jun 5, 2018
    Change-Id: I7752b30f0fabed07282d959e1ad313af072fdea5
Commits on Jun 6, 2018
  1. convert windows line endings to unix format

    dhellmann committed Jun 6, 2018
    Under python 3 the linter does not like line endings with \r\n so
    replace them with just \n.
    
    Change-Id: I6728ee3fc39a5b22ca06fcd9055872271ab79a53
    Signed-off-by: Doug Hellmann <doug@doughellmann.com>
  2. Add glance-eventlet-ssl-handshake-broken-py35 job

    ostackbrian committed May 29, 2018
    Blacklist the two currently skipped functional-py35 tests and
    include them in a new non-voting job so that their failure is
    obvious instead of hidden.
    
    Change-Id: Ice8e114c6590b25f3ec79fbe4c06efaa245706c0
    Partial-bug: #1769006
Commits on Jun 5, 2018
  1. Merge "Modify the empty list ensure method"

    Zuul authored and openstack-gerrit committed Jun 5, 2018
  2. Merge "Update pypi url to new url"

    Zuul authored and openstack-gerrit committed Jun 5, 2018