Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1252005 #30

Closed
wants to merge 3 commits into from
Closed

Bug/1252005 #30

wants to merge 3 commits into from

Conversation

babitha31
Copy link
Contributor

No description provided.

@babitha31 babitha31 closed this Dec 2, 2013
@babitha31 babitha31 reopened this Dec 2, 2013
@mrunge
Copy link
Contributor

mrunge commented Dec 2, 2013

thank you for the patch. horizon uses gerrit for code contributions and launchpad for bug tracking.

@babitha31
Copy link
Contributor Author

could you please help me in setting up with gerrit to contribute this patch

@Ladas
Copy link
Contributor

Ladas commented Dec 2, 2013

I think following this is the best option: https://wiki.openstack.org/wiki/GerritWorkflow ,thank you for your contribution.

@babitha31
Copy link
Contributor Author

thank you ladas.even i followed the same procedure.It works fine upto "git commit -a".But when i enter the command "git review",an exception raises as
ssh: could not resolve hostname ssh: Name or service not known
fatal: The remote end hung up unexpectedly

error: could not fetch gerrit

I got stuck here since few weeks.could you pls help me in sorting this out.

@Ladas
Copy link
Contributor

Ladas commented Dec 2, 2013

Do you have 'Change-Id:' in your commit message?

Also have you tried this? git remote add gerrit ssh://@review.openstack.org:29418/openstack/nova.git

The user have to exist, and you have to add your RSA public key here https://review.openstack.org/#/settings/ssh-keys

@babitha31
Copy link
Contributor Author

the second and third steps have been done without any error.But I didn't get any Change-Id when i commit my code

@openstack-gerrit
Copy link

Thank you for contributing to openstack/horizon!

openstack/horizon uses Gerrit for code review.

Please visit http://wiki.openstack.org/GerritWorkflow and follow the
instructions there to upload your change to Gerrit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants