-
Notifications
You must be signed in to change notification settings - Fork 43
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce API for aborting introspection
It is not currently possible to stop a running introspection. This may be annoying for the operator, considering the amount of time it takes for the bare metal node to call the continue API request, especially knowing the introspection will fail/time-out eventually (such as when debugging). This patch introduces a REST API endpoint "POST /v1/introspection/<node-UUID>/abort" in order to fill the gap. Upon the abort method call, following preconditions are checked: * there's a bare metal node matching the UUID * introspection was not finished for the node * introspection process is waiting for the node to give the continue call Following Responses are returned to the caller in case the preconditions were not met: * 404 Response in case node wasn't found * 409 Response (resource busy) in case the introspection process is not waiting for the Continue call Otherwise, a 202 Response is returned. When the abort method is processed, the node is powered off and it is black-listed in inspector's firewall to prevent it from booting the introspection image. This happens asynchronously. To prevent interference with the continue call processing, the processing method was updated to give a 400 Response to the introspection client in case continuing a finished or canceled introspection. Limitations: * IMPI credentials are never updated in case introspection was canceled * 202 response is returned even if the introspection was already finished * the endpoint differs from requested "DELETE /v1/introspection/<node-UUID>" Links: [1] https://bugs.launchpad.net/ironic-inspector/+bug/1525235 Change-Id: If043171f0d292ae2775dc1f26233dd4911599247 Closes-Bug: #1525235
- Loading branch information
Showing
9 changed files
with
283 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
features: | ||
- Introduced API "POST /v1/introspection/<UUID>/abort" for aborting | ||
the introspection process. |