Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge "Replace assertTrue(not *) with assertFalse(*)"

  • Loading branch information...
commit 64d0c42289930635083acee234fc44de36a0d22c 2 parents 568f9b3 + acaf3bc
Jenkins authored openstack-gerrit committed
View
2  nova/tests/db/test_migrations.py
@@ -865,4 +865,4 @@ def test_all_migrations_have_downgrade(self):
helpful_msg = (_("The following migrations are missing a downgrade:"
"\n\t%s") % '\n\t'.join(sorted(missing_downgrade)))
- self.assertTrue(not missing_downgrade, helpful_msg)
+ self.assertFalse(missing_downgrade, helpful_msg)
View
2  nova/tests/test_service.py
@@ -103,7 +103,7 @@ def test_service_enabled_on_create_based_on_flag(self):
app.stop()
ref = db.service_get(context.get_admin_context(), app.service_id)
db.service_destroy(context.get_admin_context(), app.service_id)
- self.assertTrue(not ref['disabled'])
+ self.assertFalse(ref['disabled'])
def test_service_disabled_on_create_based_on_flag(self):
self.flags(enable_new_services=False)
View
2  nova/tests/virt/xenapi/test_xenapi.py
@@ -527,7 +527,7 @@ def fake_image_upload(_self, ctx, session, inst, vdi_uuids,
for vdi_ref in xenapi_fake.get_all('VDI'):
vdi_rec = xenapi_fake.get_record('VDI', vdi_ref)
name_label = vdi_rec["name_label"]
- self.assertTrue(not name_label.endswith('snapshot'))
+ self.assertFalse(name_label.endswith('snapshot'))
self.assertTrue(self.fake_upload_called)
Please sign in to comment.
Something went wrong with that request. Please try again.