From e74daab183227be1b43e5425d6edc8e6fdab0312 Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Sat, 8 Mar 2014 16:31:00 -0600 Subject: [PATCH 01/16] Use the Additional Reference Links plug-in for SHFB to address build warnings --- .../AdditionalReferenceDocumentation.shfbproj | 54 +++++++++++++++++++ src/Documentation/Documentation.v3.5.shfbproj | 7 +++ src/Documentation/Documentation.v4.0.shfbproj | 7 +++ src/openstack.net.sln | 10 ++++ 4 files changed, 78 insertions(+) create mode 100644 src/Documentation/AdditionalReferenceDocumentation.shfbproj diff --git a/src/Documentation/AdditionalReferenceDocumentation.shfbproj b/src/Documentation/AdditionalReferenceDocumentation.shfbproj new file mode 100644 index 000000000..a382d1f30 --- /dev/null +++ b/src/Documentation/AdditionalReferenceDocumentation.shfbproj @@ -0,0 +1,54 @@ + + + + + Debug + AnyCPU + 2.0 + 1d084ab3-e5db-4a72-9daf-e51d225d5fcf + 1.9.9.0 + + AdditionalReferenceDocumentation + AdditionalReferenceDocumentation + AdditionalReferenceDocumentation + + .NET Framework 4.0 + .\Help\ + AdditionalReferenceDocumentation + en-US + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/src/Documentation/Documentation.v3.5.shfbproj b/src/Documentation/Documentation.v3.5.shfbproj index 07a74c3ba..26fa7c4bb 100644 --- a/src/Documentation/Documentation.v3.5.shfbproj +++ b/src/Documentation/Documentation.v3.5.shfbproj @@ -95,6 +95,13 @@ + + + + + + + diff --git a/src/Documentation/Documentation.v4.0.shfbproj b/src/Documentation/Documentation.v4.0.shfbproj index dd04fcb39..c8788493e 100644 --- a/src/Documentation/Documentation.v4.0.shfbproj +++ b/src/Documentation/Documentation.v4.0.shfbproj @@ -99,6 +99,13 @@ + + + + + + + diff --git a/src/openstack.net.sln b/src/openstack.net.sln index 397ce9c4a..7a6c30bfb 100644 --- a/src/openstack.net.sln +++ b/src/openstack.net.sln @@ -40,6 +40,8 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "CPPCodeSamples", "Samples\C EndProject Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "FSharpCodeSamples", "Samples\FSharpCodeSamples\FSharpCodeSamples.fsproj", "{6F852167-4873-4541-A4FF-F4D9E396927B}" EndProject +Project("{7CF6DF6D-3B04-46F8-A40B-537D21BCA0B4}") = "AdditionalReferenceDocumentation", "Documentation\AdditionalReferenceDocumentation.shfbproj", "{1D084AB3-E5DB-4A72-9DAF-E51D225D5FCF}" +EndProject Global GlobalSection(TestCaseManagementSettings) = postSolution CategoryFile = openstack.net.vsmdi @@ -187,6 +189,14 @@ Global {6F852167-4873-4541-A4FF-F4D9E396927B}.Release|Mixed Platforms.Build.0 = Release|Any CPU {6F852167-4873-4541-A4FF-F4D9E396927B}.Release|Win32.ActiveCfg = Release|Any CPU {6F852167-4873-4541-A4FF-F4D9E396927B}.Release|x86.ActiveCfg = Release|Any CPU + {1D084AB3-E5DB-4A72-9DAF-E51D225D5FCF}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {1D084AB3-E5DB-4A72-9DAF-E51D225D5FCF}.Debug|Mixed Platforms.ActiveCfg = Debug|Any CPU + {1D084AB3-E5DB-4A72-9DAF-E51D225D5FCF}.Debug|Win32.ActiveCfg = Debug|Any CPU + {1D084AB3-E5DB-4A72-9DAF-E51D225D5FCF}.Debug|x86.ActiveCfg = Debug|Any CPU + {1D084AB3-E5DB-4A72-9DAF-E51D225D5FCF}.Release|Any CPU.ActiveCfg = Release|Any CPU + {1D084AB3-E5DB-4A72-9DAF-E51D225D5FCF}.Release|Mixed Platforms.ActiveCfg = Release|Any CPU + {1D084AB3-E5DB-4A72-9DAF-E51D225D5FCF}.Release|Win32.ActiveCfg = Release|Any CPU + {1D084AB3-E5DB-4A72-9DAF-E51D225D5FCF}.Release|x86.ActiveCfg = Release|Any CPU EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE From 5aee348775d31af26374b00c383df394c7114495 Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Sat, 8 Mar 2014 17:06:03 -0600 Subject: [PATCH 02/16] Add missing summary documentation for namespaces --- src/corelib/Core/Collections/NamespaceDoc.cs | 13 +++++++++++++ src/corelib/corelib.v3.5.csproj | 1 + src/corelib/corelib.v4.0.csproj | 1 + 3 files changed, 15 insertions(+) create mode 100644 src/corelib/Core/Collections/NamespaceDoc.cs diff --git a/src/corelib/Core/Collections/NamespaceDoc.cs b/src/corelib/Core/Collections/NamespaceDoc.cs new file mode 100644 index 000000000..0f7adbb79 --- /dev/null +++ b/src/corelib/Core/Collections/NamespaceDoc.cs @@ -0,0 +1,13 @@ +namespace net.openstack.Core.Collections +{ + using System.Runtime.CompilerServices; + + /// + /// The namespace contains interfaces and + /// classes that extend the collections support provided by the base class library. + /// + [CompilerGenerated] + internal class NamespaceDoc + { + } +} diff --git a/src/corelib/corelib.v3.5.csproj b/src/corelib/corelib.v3.5.csproj index 04add640c..f3b941d29 100644 --- a/src/corelib/corelib.v3.5.csproj +++ b/src/corelib/corelib.v3.5.csproj @@ -69,6 +69,7 @@ + diff --git a/src/corelib/corelib.v4.0.csproj b/src/corelib/corelib.v4.0.csproj index aa9bd31ab..690207529 100644 --- a/src/corelib/corelib.v4.0.csproj +++ b/src/corelib/corelib.v4.0.csproj @@ -64,6 +64,7 @@ + From bffcba69c84984ca128fdae1545231edb780c487 Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Sat, 8 Mar 2014 17:07:45 -0600 Subject: [PATCH 03/16] Add missing returns documentation for FromName methods --- src/corelib/Core/Domain/AuthenticationType.cs | 1 + src/corelib/Core/Domain/DiskConfiguration.cs | 1 + src/corelib/Core/Domain/ImageState.cs | 1 + src/corelib/Core/Domain/ImageType.cs | 1 + src/corelib/Core/Domain/PowerState.cs | 1 + src/corelib/Core/Domain/RebootType.cs | 1 + src/corelib/Core/Domain/ServerState.cs | 1 + src/corelib/Core/Domain/SnapshotState.cs | 1 + src/corelib/Core/Domain/TaskState.cs | 1 + src/corelib/Core/Domain/VirtualMachineState.cs | 1 + src/corelib/Core/Domain/VolumeState.cs | 1 + src/corelib/Providers/Rackspace/Objects/ArchiveFormat.cs | 1 + src/corelib/Providers/Rackspace/Objects/AutoScale/LaunchType.cs | 1 + src/corelib/Providers/Rackspace/Objects/AutoScale/PolicyType.cs | 1 + .../Providers/Rackspace/Objects/Databases/BackupStatus.cs | 1 + .../Rackspace/Objects/Databases/DatabaseInstanceStatus.cs | 1 + src/corelib/Providers/Rackspace/Objects/Dns/DnsJobStatus.cs | 1 + src/corelib/Providers/Rackspace/Objects/Dns/DnsRateLimitUnit.cs | 1 + src/corelib/Providers/Rackspace/Objects/Dns/DnsRecordType.cs | 1 + src/corelib/Providers/Rackspace/Objects/Dns/LimitType.cs | 1 + .../Providers/Rackspace/Objects/Dns/SerializedDomainFormat.cs | 1 + .../Providers/Rackspace/Objects/LoadBalancers/AccessType.cs | 1 + .../Rackspace/Objects/LoadBalancers/HealthMonitorType.cs | 1 + .../Rackspace/Objects/LoadBalancers/LoadBalancerStatus.cs | 1 + .../Objects/LoadBalancers/LoadBalancerVirtualAddressType.cs | 1 + .../Rackspace/Objects/LoadBalancers/LoadBalancingAlgorithm.cs | 1 + .../Providers/Rackspace/Objects/LoadBalancers/NodeCondition.cs | 1 + .../Rackspace/Objects/LoadBalancers/NodeServiceEventCategory.cs | 1 + .../Rackspace/Objects/LoadBalancers/NodeServiceEventSeverity.cs | 1 + .../Rackspace/Objects/LoadBalancers/NodeServiceEventType.cs | 1 + .../Providers/Rackspace/Objects/LoadBalancers/NodeStatus.cs | 1 + .../Providers/Rackspace/Objects/LoadBalancers/NodeType.cs | 1 + .../Rackspace/Objects/LoadBalancers/SessionPersistenceType.cs | 1 + src/corelib/Providers/Rackspace/Objects/Monitoring/AlarmState.cs | 1 + .../Providers/Rackspace/Objects/Monitoring/CheckMetricType.cs | 1 + .../Providers/Rackspace/Objects/Monitoring/CheckTypeType.cs | 1 + .../Rackspace/Objects/Monitoring/DataPointGranularity.cs | 1 + .../Providers/Rackspace/Objects/Monitoring/DataPointStatistic.cs | 1 + .../Rackspace/Objects/Monitoring/HostInformationType.cs | 1 + .../Providers/Rackspace/Objects/Monitoring/TargetResolverType.cs | 1 + 40 files changed, 40 insertions(+) diff --git a/src/corelib/Core/Domain/AuthenticationType.cs b/src/corelib/Core/Domain/AuthenticationType.cs index c406b6df2..1932254c9 100644 --- a/src/corelib/Core/Domain/AuthenticationType.cs +++ b/src/corelib/Core/Domain/AuthenticationType.cs @@ -30,6 +30,7 @@ private AuthenticationType(string name) : base(name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static AuthenticationType FromName(string name) diff --git a/src/corelib/Core/Domain/DiskConfiguration.cs b/src/corelib/Core/Domain/DiskConfiguration.cs index b22b226d3..528a437cb 100644 --- a/src/corelib/Core/Domain/DiskConfiguration.cs +++ b/src/corelib/Core/Domain/DiskConfiguration.cs @@ -36,6 +36,7 @@ private DiskConfiguration(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static DiskConfiguration FromName(string name) diff --git a/src/corelib/Core/Domain/ImageState.cs b/src/corelib/Core/Domain/ImageState.cs index d22df6302..78e19cddb 100644 --- a/src/corelib/Core/Domain/ImageState.cs +++ b/src/corelib/Core/Domain/ImageState.cs @@ -37,6 +37,7 @@ private ImageState(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static ImageState FromName(string name) diff --git a/src/corelib/Core/Domain/ImageType.cs b/src/corelib/Core/Domain/ImageType.cs index ef2ad21df..90be5ac74 100644 --- a/src/corelib/Core/Domain/ImageType.cs +++ b/src/corelib/Core/Domain/ImageType.cs @@ -33,6 +33,7 @@ private ImageType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static ImageType FromName(string name) diff --git a/src/corelib/Core/Domain/PowerState.cs b/src/corelib/Core/Domain/PowerState.cs index 2446b3526..844196b2f 100644 --- a/src/corelib/Core/Domain/PowerState.cs +++ b/src/corelib/Core/Domain/PowerState.cs @@ -43,6 +43,7 @@ private PowerState(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static PowerState FromName(string name) diff --git a/src/corelib/Core/Domain/RebootType.cs b/src/corelib/Core/Domain/RebootType.cs index 361f059e6..91d5acecd 100644 --- a/src/corelib/Core/Domain/RebootType.cs +++ b/src/corelib/Core/Domain/RebootType.cs @@ -33,6 +33,7 @@ private RebootType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static RebootType FromName(string name) diff --git a/src/corelib/Core/Domain/ServerState.cs b/src/corelib/Core/Domain/ServerState.cs index c10003f65..bac655313 100644 --- a/src/corelib/Core/Domain/ServerState.cs +++ b/src/corelib/Core/Domain/ServerState.cs @@ -49,6 +49,7 @@ private ServerState(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static ServerState FromName(string name) diff --git a/src/corelib/Core/Domain/SnapshotState.cs b/src/corelib/Core/Domain/SnapshotState.cs index cfcfdfb3c..2c1243529 100644 --- a/src/corelib/Core/Domain/SnapshotState.cs +++ b/src/corelib/Core/Domain/SnapshotState.cs @@ -36,6 +36,7 @@ private SnapshotState(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static SnapshotState FromName(string name) diff --git a/src/corelib/Core/Domain/TaskState.cs b/src/corelib/Core/Domain/TaskState.cs index 7f1f14e9c..5cb52dd72 100644 --- a/src/corelib/Core/Domain/TaskState.cs +++ b/src/corelib/Core/Domain/TaskState.cs @@ -71,6 +71,7 @@ private TaskState(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static TaskState FromName(string name) diff --git a/src/corelib/Core/Domain/VirtualMachineState.cs b/src/corelib/Core/Domain/VirtualMachineState.cs index 1e7a6f3f0..6098644e4 100644 --- a/src/corelib/Core/Domain/VirtualMachineState.cs +++ b/src/corelib/Core/Domain/VirtualMachineState.cs @@ -49,6 +49,7 @@ private VirtualMachineState(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static VirtualMachineState FromName(string name) diff --git a/src/corelib/Core/Domain/VolumeState.cs b/src/corelib/Core/Domain/VolumeState.cs index 386cf84c1..6ed16bbbb 100644 --- a/src/corelib/Core/Domain/VolumeState.cs +++ b/src/corelib/Core/Domain/VolumeState.cs @@ -38,6 +38,7 @@ private VolumeState(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static VolumeState FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/ArchiveFormat.cs b/src/corelib/Providers/Rackspace/Objects/ArchiveFormat.cs index 1b0f19611..183f1930c 100644 --- a/src/corelib/Providers/Rackspace/Objects/ArchiveFormat.cs +++ b/src/corelib/Providers/Rackspace/Objects/ArchiveFormat.cs @@ -38,6 +38,7 @@ private ArchiveFormat(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static ArchiveFormat FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/AutoScale/LaunchType.cs b/src/corelib/Providers/Rackspace/Objects/AutoScale/LaunchType.cs index 98c7daf60..858047d21 100644 --- a/src/corelib/Providers/Rackspace/Objects/AutoScale/LaunchType.cs +++ b/src/corelib/Providers/Rackspace/Objects/AutoScale/LaunchType.cs @@ -34,6 +34,7 @@ private LaunchType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static LaunchType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/AutoScale/PolicyType.cs b/src/corelib/Providers/Rackspace/Objects/AutoScale/PolicyType.cs index 08b865ef9..c64ecff73 100644 --- a/src/corelib/Providers/Rackspace/Objects/AutoScale/PolicyType.cs +++ b/src/corelib/Providers/Rackspace/Objects/AutoScale/PolicyType.cs @@ -36,6 +36,7 @@ private PolicyType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static PolicyType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Databases/BackupStatus.cs b/src/corelib/Providers/Rackspace/Objects/Databases/BackupStatus.cs index 92b54dc85..ee4c98f95 100644 --- a/src/corelib/Providers/Rackspace/Objects/Databases/BackupStatus.cs +++ b/src/corelib/Providers/Rackspace/Objects/Databases/BackupStatus.cs @@ -36,6 +36,7 @@ private BackupStatus(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static BackupStatus FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Databases/DatabaseInstanceStatus.cs b/src/corelib/Providers/Rackspace/Objects/Databases/DatabaseInstanceStatus.cs index fd1498e88..1ce337629 100644 --- a/src/corelib/Providers/Rackspace/Objects/Databases/DatabaseInstanceStatus.cs +++ b/src/corelib/Providers/Rackspace/Objects/Databases/DatabaseInstanceStatus.cs @@ -42,6 +42,7 @@ private DatabaseInstanceStatus(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static DatabaseInstanceStatus FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Dns/DnsJobStatus.cs b/src/corelib/Providers/Rackspace/Objects/Dns/DnsJobStatus.cs index 92c7202ff..52bb078af 100644 --- a/src/corelib/Providers/Rackspace/Objects/Dns/DnsJobStatus.cs +++ b/src/corelib/Providers/Rackspace/Objects/Dns/DnsJobStatus.cs @@ -38,6 +38,7 @@ private DnsJobStatus(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static DnsJobStatus FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Dns/DnsRateLimitUnit.cs b/src/corelib/Providers/Rackspace/Objects/Dns/DnsRateLimitUnit.cs index 4629246c3..a0b5797c8 100644 --- a/src/corelib/Providers/Rackspace/Objects/Dns/DnsRateLimitUnit.cs +++ b/src/corelib/Providers/Rackspace/Objects/Dns/DnsRateLimitUnit.cs @@ -35,6 +35,7 @@ private DnsRateLimitUnit(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static DnsRateLimitUnit FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Dns/DnsRecordType.cs b/src/corelib/Providers/Rackspace/Objects/Dns/DnsRecordType.cs index 144441953..8d927adf0 100644 --- a/src/corelib/Providers/Rackspace/Objects/Dns/DnsRecordType.cs +++ b/src/corelib/Providers/Rackspace/Objects/Dns/DnsRecordType.cs @@ -42,6 +42,7 @@ private DnsRecordType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static DnsRecordType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Dns/LimitType.cs b/src/corelib/Providers/Rackspace/Objects/Dns/LimitType.cs index 6132b4e25..d34060e39 100644 --- a/src/corelib/Providers/Rackspace/Objects/Dns/LimitType.cs +++ b/src/corelib/Providers/Rackspace/Objects/Dns/LimitType.cs @@ -39,6 +39,7 @@ private LimitType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static LimitType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Dns/SerializedDomainFormat.cs b/src/corelib/Providers/Rackspace/Objects/Dns/SerializedDomainFormat.cs index 91e9e4827..2bd25cb18 100644 --- a/src/corelib/Providers/Rackspace/Objects/Dns/SerializedDomainFormat.cs +++ b/src/corelib/Providers/Rackspace/Objects/Dns/SerializedDomainFormat.cs @@ -34,6 +34,7 @@ private SerializedDomainFormat(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static SerializedDomainFormat FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/AccessType.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/AccessType.cs index 3e63a4dc1..8b45859ea 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/AccessType.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/AccessType.cs @@ -36,6 +36,7 @@ private AccessType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static AccessType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/HealthMonitorType.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/HealthMonitorType.cs index 92dc2c815..637adbfbc 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/HealthMonitorType.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/HealthMonitorType.cs @@ -37,6 +37,7 @@ private HealthMonitorType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static HealthMonitorType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerStatus.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerStatus.cs index dc9a2a856..d70b01e7b 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerStatus.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerStatus.cs @@ -42,6 +42,7 @@ private LoadBalancerStatus(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static LoadBalancerStatus FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerVirtualAddressType.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerVirtualAddressType.cs index c367d71cd..8043a55ad 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerVirtualAddressType.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerVirtualAddressType.cs @@ -48,6 +48,7 @@ private LoadBalancerVirtualAddressType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static LoadBalancerVirtualAddressType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancingAlgorithm.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancingAlgorithm.cs index 848aec0b1..38be92644 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancingAlgorithm.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancingAlgorithm.cs @@ -41,6 +41,7 @@ private LoadBalancingAlgorithm(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static LoadBalancingAlgorithm FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeCondition.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeCondition.cs index b59e1a4d1..3d659c818 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeCondition.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeCondition.cs @@ -39,6 +39,7 @@ private NodeCondition(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static NodeCondition FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventCategory.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventCategory.cs index 1ef868193..c464611c5 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventCategory.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventCategory.cs @@ -35,6 +35,7 @@ private NodeServiceEventCategory(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static NodeServiceEventCategory FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventSeverity.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventSeverity.cs index c002cc940..ed37a36a4 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventSeverity.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventSeverity.cs @@ -35,6 +35,7 @@ private NodeServiceEventSeverity(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static NodeServiceEventSeverity FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventType.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventType.cs index 0646460ad..bfc4ff0ef 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventType.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeServiceEventType.cs @@ -35,6 +35,7 @@ private NodeServiceEventType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static NodeServiceEventType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeStatus.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeStatus.cs index 0972692c1..04332b008 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeStatus.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeStatus.cs @@ -35,6 +35,7 @@ private NodeStatus(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static NodeStatus FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeType.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeType.cs index a19053739..4d143297f 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeType.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/NodeType.cs @@ -36,6 +36,7 @@ private NodeType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static NodeType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/SessionPersistenceType.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/SessionPersistenceType.cs index 0d4193c6e..772a17dc8 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/SessionPersistenceType.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/SessionPersistenceType.cs @@ -35,6 +35,7 @@ private SessionPersistenceType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static SessionPersistenceType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Monitoring/AlarmState.cs b/src/corelib/Providers/Rackspace/Objects/Monitoring/AlarmState.cs index b9893cac6..dac3257a3 100644 --- a/src/corelib/Providers/Rackspace/Objects/Monitoring/AlarmState.cs +++ b/src/corelib/Providers/Rackspace/Objects/Monitoring/AlarmState.cs @@ -36,6 +36,7 @@ private AlarmState(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static AlarmState FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Monitoring/CheckMetricType.cs b/src/corelib/Providers/Rackspace/Objects/Monitoring/CheckMetricType.cs index 00006164e..72bd99a21 100644 --- a/src/corelib/Providers/Rackspace/Objects/Monitoring/CheckMetricType.cs +++ b/src/corelib/Providers/Rackspace/Objects/Monitoring/CheckMetricType.cs @@ -36,6 +36,7 @@ private CheckMetricType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static CheckMetricType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Monitoring/CheckTypeType.cs b/src/corelib/Providers/Rackspace/Objects/Monitoring/CheckTypeType.cs index 8679fff42..fbf3e3023 100644 --- a/src/corelib/Providers/Rackspace/Objects/Monitoring/CheckTypeType.cs +++ b/src/corelib/Providers/Rackspace/Objects/Monitoring/CheckTypeType.cs @@ -35,6 +35,7 @@ private CheckTypeType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static CheckTypeType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Monitoring/DataPointGranularity.cs b/src/corelib/Providers/Rackspace/Objects/Monitoring/DataPointGranularity.cs index de2946e5d..139d05933 100644 --- a/src/corelib/Providers/Rackspace/Objects/Monitoring/DataPointGranularity.cs +++ b/src/corelib/Providers/Rackspace/Objects/Monitoring/DataPointGranularity.cs @@ -39,6 +39,7 @@ private DataPointGranularity(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static DataPointGranularity FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Monitoring/DataPointStatistic.cs b/src/corelib/Providers/Rackspace/Objects/Monitoring/DataPointStatistic.cs index 4465b6397..23749a48a 100644 --- a/src/corelib/Providers/Rackspace/Objects/Monitoring/DataPointStatistic.cs +++ b/src/corelib/Providers/Rackspace/Objects/Monitoring/DataPointStatistic.cs @@ -38,6 +38,7 @@ private DataPointStatistic(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static DataPointStatistic FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Monitoring/HostInformationType.cs b/src/corelib/Providers/Rackspace/Objects/Monitoring/HostInformationType.cs index 1765decae..88cc75f08 100644 --- a/src/corelib/Providers/Rackspace/Objects/Monitoring/HostInformationType.cs +++ b/src/corelib/Providers/Rackspace/Objects/Monitoring/HostInformationType.cs @@ -41,6 +41,7 @@ private HostInformationType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static HostInformationType FromName(string name) diff --git a/src/corelib/Providers/Rackspace/Objects/Monitoring/TargetResolverType.cs b/src/corelib/Providers/Rackspace/Objects/Monitoring/TargetResolverType.cs index e754422d7..5aeafa294 100644 --- a/src/corelib/Providers/Rackspace/Objects/Monitoring/TargetResolverType.cs +++ b/src/corelib/Providers/Rackspace/Objects/Monitoring/TargetResolverType.cs @@ -35,6 +35,7 @@ private TargetResolverType(string name) /// Gets the instance with the specified name. /// /// The name. + /// The unique instance with the specified name. /// If is . /// If is empty. public static TargetResolverType FromName(string name) From 5acd7c8bc170090bcee6096540325b26b8bf434c Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Sun, 9 Mar 2014 14:22:09 -0500 Subject: [PATCH 04/16] Add missing documentation elements --- src/corelib/Core/Domain/Queues/Claim.cs | 1 + .../Core/Providers/IQueueingService.cs | 2 ++ .../Core/Synchronous/DnsServiceExtensions.cs | 1 + .../MonitoringServiceExtensions.cs | 2 +- ...OnlyCollectionPageSynchronousExtensions.cs | 1 + .../Providers/Rackspace/IMonitoringService.cs | 2 +- .../Rackspace/Objects/AutoScale/LaunchType.cs | 1 + .../Objects/AutoScale/NamespaceDoc.cs | 14 ++++++++++ .../Rackspace/Objects/AutoScale/PolicyType.cs | 1 + .../AutoScale/ServerLaunchArguments.cs | 2 +- .../DatabaseInstanceConfiguration.cs | 26 ++++++++++++++----- .../LoadBalancerVirtualAddress.cs | 3 ++- .../Providers/Rackspace/ProviderBase`1.cs | 16 +++++++++++- src/corelib/corelib.v3.5.csproj | 1 + src/corelib/corelib.v4.0.csproj | 1 + 15 files changed, 62 insertions(+), 12 deletions(-) create mode 100644 src/corelib/Providers/Rackspace/Objects/AutoScale/NamespaceDoc.cs diff --git a/src/corelib/Core/Domain/Queues/Claim.cs b/src/corelib/Core/Domain/Queues/Claim.cs index 7bccaf47d..aa647b380 100644 --- a/src/corelib/Core/Domain/Queues/Claim.cs +++ b/src/corelib/Core/Domain/Queues/Claim.cs @@ -254,6 +254,7 @@ public void Dispose() /// claimed by this claim. To prevent other subscribers from re-claiming the messages, make /// sure to delete the messages before calling . /// + /// The that the task will observe. /// A object representing the asynchronous operation. public Task DisposeAsync(CancellationToken cancellationToken) { diff --git a/src/corelib/Core/Providers/IQueueingService.cs b/src/corelib/Core/Providers/IQueueingService.cs index 0fa12b1bf..c3ef6ef62 100644 --- a/src/corelib/Core/Providers/IQueueingService.cs +++ b/src/corelib/Core/Providers/IQueueingService.cs @@ -344,6 +344,7 @@ Task GetQueueMetadataAsync(QueueName queueName, CancellationToken cancella /// The queue name. /// The messages to post. /// The that the task will observe. + /// The class modeling the JSON representation of the messages to post in the queue. /// A object representing the asynchronous operation. /// /// If is . @@ -363,6 +364,7 @@ Task GetQueueMetadataAsync(QueueName queueName, CancellationToken cancella /// The queue name. /// The that the task will observe. /// The messages to post. + /// The class modeling the JSON representation of the messages to post in the queue. /// A object representing the asynchronous operation. /// /// If is . diff --git a/src/corelib/Core/Synchronous/DnsServiceExtensions.cs b/src/corelib/Core/Synchronous/DnsServiceExtensions.cs index f410943b2..e6a20363f 100644 --- a/src/corelib/Core/Synchronous/DnsServiceExtensions.cs +++ b/src/corelib/Core/Synchronous/DnsServiceExtensions.cs @@ -145,6 +145,7 @@ public static DnsJob GetJobStatus(this IDnsService service, DnsJob job, bool sho /// /// Gets information about an asynchronous task with a strongly-typed result being executed by the DNS service. /// + /// The class modeling the JSON result of the asynchronous operation. /// The DNS service instance. /// The to query. /// to include detailed information about the job; otherwise, . diff --git a/src/corelib/Core/Synchronous/MonitoringServiceExtensions.cs b/src/corelib/Core/Synchronous/MonitoringServiceExtensions.cs index 5f6020027..74d6a36c7 100644 --- a/src/corelib/Core/Synchronous/MonitoringServiceExtensions.cs +++ b/src/corelib/Core/Synchronous/MonitoringServiceExtensions.cs @@ -2454,7 +2454,7 @@ public static HostInformation> GetLoginInfo /// Gets a collection of monitoring agent check targets. /// /// The monitoring service instance. - /// + /// The entity ID. This is obtained from Entity.Id. /// The agent check type ID. This is obtained from CheckType.Id, or from the predefined values in . /// A marker identifying the next page of results. This parameter is used for pagination, and is obtained from . If the value is , the list starts at the beginning. /// The maximum number of items to include in a single page of results. This parameter is used for pagination. If the value is , a provider-specific default value is used. diff --git a/src/corelib/Core/Synchronous/ReadOnlyCollectionPageSynchronousExtensions.cs b/src/corelib/Core/Synchronous/ReadOnlyCollectionPageSynchronousExtensions.cs index d4580308c..218ce657a 100644 --- a/src/corelib/Core/Synchronous/ReadOnlyCollectionPageSynchronousExtensions.cs +++ b/src/corelib/Core/Synchronous/ReadOnlyCollectionPageSynchronousExtensions.cs @@ -52,6 +52,7 @@ public static ReadOnlyCollection GetAllPages(this ReadOnlyCollectionPage /// Gets the next page in the paginated collection. /// + /// The type of elements in the collection. /// A page of a paginated collection. /// A collection containing the next page of results. /// If is . diff --git a/src/corelib/Providers/Rackspace/IMonitoringService.cs b/src/corelib/Providers/Rackspace/IMonitoringService.cs index 24120619d..f51abb20c 100644 --- a/src/corelib/Providers/Rackspace/IMonitoringService.cs +++ b/src/corelib/Providers/Rackspace/IMonitoringService.cs @@ -1405,7 +1405,7 @@ public interface IMonitoringService /// /// Gets a collection of monitoring agent check targets. /// - /// + /// The entity ID. This is obtained from Entity.Id. /// The agent check type ID. This is obtained from CheckType.Id, or from the predefined values in . /// A marker identifying the next page of results. This parameter is used for pagination, and is obtained from . If the value is , the list starts at the beginning. /// The maximum number of items to include in a single page of results. This parameter is used for pagination. If the value is , a provider-specific default value is used. diff --git a/src/corelib/Providers/Rackspace/Objects/AutoScale/LaunchType.cs b/src/corelib/Providers/Rackspace/Objects/AutoScale/LaunchType.cs index 858047d21..104c862b8 100644 --- a/src/corelib/Providers/Rackspace/Objects/AutoScale/LaunchType.cs +++ b/src/corelib/Providers/Rackspace/Objects/AutoScale/LaunchType.cs @@ -6,6 +6,7 @@ using Newtonsoft.Json; /// + /// Represents an Auto Scale launch type. /// /// /// This class functions as a strongly-typed enumeration of known launch types, diff --git a/src/corelib/Providers/Rackspace/Objects/AutoScale/NamespaceDoc.cs b/src/corelib/Providers/Rackspace/Objects/AutoScale/NamespaceDoc.cs new file mode 100644 index 000000000..cb35c0b4d --- /dev/null +++ b/src/corelib/Providers/Rackspace/Objects/AutoScale/NamespaceDoc.cs @@ -0,0 +1,14 @@ +namespace net.openstack.Providers.Rackspace.Objects.AutoScale +{ + using System.Runtime.CompilerServices; + + /// + /// The namespace defines + /// the object model for communicating with Rackspace's Cloud Auto Scale service over REST APIs. + /// + /// + [CompilerGenerated] + internal class NamespaceDoc + { + } +} diff --git a/src/corelib/Providers/Rackspace/Objects/AutoScale/PolicyType.cs b/src/corelib/Providers/Rackspace/Objects/AutoScale/PolicyType.cs index c64ecff73..4e78dda90 100644 --- a/src/corelib/Providers/Rackspace/Objects/AutoScale/PolicyType.cs +++ b/src/corelib/Providers/Rackspace/Objects/AutoScale/PolicyType.cs @@ -6,6 +6,7 @@ using Newtonsoft.Json; /// + /// Represents an Auto Scale policy type. /// /// /// This class functions as a strongly-typed enumeration of known policy types, diff --git a/src/corelib/Providers/Rackspace/Objects/AutoScale/ServerLaunchArguments.cs b/src/corelib/Providers/Rackspace/Objects/AutoScale/ServerLaunchArguments.cs index a57b89398..34230ec51 100644 --- a/src/corelib/Providers/Rackspace/Objects/AutoScale/ServerLaunchArguments.cs +++ b/src/corelib/Providers/Rackspace/Objects/AutoScale/ServerLaunchArguments.cs @@ -40,7 +40,7 @@ protected ServerLaunchArguments() /// Initializes a new instance of the class /// with the specified server argument. /// - /// + /// A object containing the detailed arguments for launching a server. public ServerLaunchArguments(ServerArgument server) : this(server, null) { diff --git a/src/corelib/Providers/Rackspace/Objects/Databases/DatabaseInstanceConfiguration.cs b/src/corelib/Providers/Rackspace/Objects/Databases/DatabaseInstanceConfiguration.cs index 19a25f5c4..743e4df5c 100644 --- a/src/corelib/Providers/Rackspace/Objects/Databases/DatabaseInstanceConfiguration.cs +++ b/src/corelib/Providers/Rackspace/Objects/Databases/DatabaseInstanceConfiguration.cs @@ -49,9 +49,15 @@ protected DatabaseInstanceConfiguration() /// Initializes a new instance of the class /// with the specified values. /// - /// - /// - /// + /// A object describing the flavor of the database instance. + /// A object containing additional information about + /// the database instance storage volume. + /// The name of the database instance, or if the database instance is not named. + /// + /// If is . + /// -or- + /// If is . + /// public DatabaseInstanceConfiguration(FlavorRef flavorRef, DatabaseVolumeConfiguration volumeConfiguration, string name) : this(flavorRef, volumeConfiguration, name, null) { @@ -61,10 +67,16 @@ public DatabaseInstanceConfiguration(FlavorRef flavorRef, DatabaseVolumeConfigur /// Initializes a new instance of the class /// with a restore point for restoring a database instance from a backup. /// - /// - /// - /// - /// + /// A object describing the flavor of the database instance. + /// A object containing additional information about + /// the database instance storage volume. + /// The name of the database instance, or if the database instance is not named. + /// A object describing the backup from which this database instance was restored, or null if the restore point is not available. + /// + /// If is . + /// -or- + /// If is . + /// public DatabaseInstanceConfiguration(FlavorRef flavorRef, DatabaseVolumeConfiguration volumeConfiguration, string name, RestorePoint restorePoint) { if (flavorRef == null) diff --git a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerVirtualAddress.cs b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerVirtualAddress.cs index 99432bb0d..f976199de 100644 --- a/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerVirtualAddress.cs +++ b/src/corelib/Providers/Rackspace/Objects/LoadBalancers/LoadBalancerVirtualAddress.cs @@ -68,8 +68,9 @@ public LoadBalancerVirtualAddress(LoadBalancerVirtualAddressType type) /// with the specified virtual address type and family. /// /// The virtual address type. - /// + /// The address family for this virtual address, or to not specify the address family. /// If is . + /// If is not or . public LoadBalancerVirtualAddress(LoadBalancerVirtualAddressType type, AddressFamily? version) { if (type == null) diff --git a/src/corelib/Providers/Rackspace/ProviderBase`1.cs b/src/corelib/Providers/Rackspace/ProviderBase`1.cs index 079f49a17..1ce5c839f 100644 --- a/src/corelib/Providers/Rackspace/ProviderBase`1.cs +++ b/src/corelib/Providers/Rackspace/ProviderBase`1.cs @@ -24,6 +24,7 @@ namespace net.openstack.Providers.Rackspace /// /// Adds common functionality for all Rackspace Providers. /// + /// The service provider interface this object implements. /// public abstract class ProviderBase where TProvider : class @@ -766,8 +767,20 @@ protected virtual string GetInternalServiceEndpoint(CloudIdentity identity, stri return endpoint.InternalURL; } + /// + /// Validate the response to an HTTP request. + /// + /// + /// The validation is performed by calling . + /// + /// The response to the HTTP request. + /// If is . + /// If indicates the REST API call failed. internal void CheckResponse(Response response) { + if (response == null) + throw new ArgumentNullException("response"); + ResponseCodeValidator.Validate(response); } @@ -919,6 +932,7 @@ protected Func>, HttpWebRequest> PrepareRequestAs /// to create and prepare the resulting , and then asynchronously obtains /// the request stream for the request and writes the specified in JSON notation. /// + /// The type modeling the body of the request. /// The to use for the request. /// The for the target URI. /// A collection of parameters for binding the URI template in a call to . @@ -963,7 +977,7 @@ protected Func>, Task> PrepareReq /// /// The object modeling the body of the request. /// The object for the request. - /// + /// The object modeling the body of the request. /// The encoded content to send with the . /// If is . /// diff --git a/src/corelib/corelib.v3.5.csproj b/src/corelib/corelib.v3.5.csproj index f3b941d29..bf1dd458a 100644 --- a/src/corelib/corelib.v3.5.csproj +++ b/src/corelib/corelib.v3.5.csproj @@ -242,6 +242,7 @@ + diff --git a/src/corelib/corelib.v4.0.csproj b/src/corelib/corelib.v4.0.csproj index 690207529..a7f8a367e 100644 --- a/src/corelib/corelib.v4.0.csproj +++ b/src/corelib/corelib.v4.0.csproj @@ -232,6 +232,7 @@ + From 4dcd280117cdb0ef0129f95fd84c60d90c5ddb68 Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Mon, 10 Mar 2014 06:10:24 -0500 Subject: [PATCH 05/16] Rename parameters so works properly --- .../Core/Collections/ReadOnlyDictionary`2.cs | 16 ++++++++-------- src/corelib/Core/HttpStatusCodeParser.cs | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/corelib/Core/Collections/ReadOnlyDictionary`2.cs b/src/corelib/Core/Collections/ReadOnlyDictionary`2.cs index 8d6eee391..d6d9364e0 100644 --- a/src/corelib/Core/Collections/ReadOnlyDictionary`2.cs +++ b/src/corelib/Core/Collections/ReadOnlyDictionary`2.cs @@ -442,17 +442,17 @@ IEnumerator IEnumerable.GetEnumerator() return GetEnumerator(); } - bool ICollection.Contains(TKey value) + bool ICollection.Contains(TKey item) { - return _keys.Contains(value); + return _keys.Contains(item); } - void ICollection.Add(TKey value) + void ICollection.Add(TKey item) { throw new NotSupportedException(); } - bool ICollection.Remove(TKey value) + bool ICollection.Remove(TKey item) { throw new NotSupportedException(); } @@ -564,17 +564,17 @@ IEnumerator IEnumerable.GetEnumerator() return GetEnumerator(); } - bool ICollection.Contains(TValue value) + bool ICollection.Contains(TValue item) { - return _values.Contains(value); + return _values.Contains(item); } - void ICollection.Add(TValue value) + void ICollection.Add(TValue item) { throw new NotSupportedException(); } - bool ICollection.Remove(TValue value) + bool ICollection.Remove(TValue item) { throw new NotSupportedException(); } diff --git a/src/corelib/Core/HttpStatusCodeParser.cs b/src/corelib/Core/HttpStatusCodeParser.cs index b568c47ed..d943d29b3 100644 --- a/src/corelib/Core/HttpStatusCodeParser.cs +++ b/src/corelib/Core/HttpStatusCodeParser.cs @@ -78,18 +78,18 @@ public static HttpStatusCodeParser Default } /// - public virtual bool TryParse(string value, out Status result) + public virtual bool TryParse(string value, out Status status) { if (value == null) { - result = null; + status = null; return false; } var match = _expression.Match(value); if (!match.Success) { - result = null; + status = null; return false; } @@ -98,7 +98,7 @@ public virtual bool TryParse(string value, out Status result) if (string.IsNullOrEmpty(description)) description = statusCode.ToString(); - result = new Status((int)statusCode, description); + status = new Status((int)statusCode, description); return true; } } From bb1ed4d752f0108840877e0898c734c9d26a7d91 Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Mon, 10 Mar 2014 06:11:11 -0500 Subject: [PATCH 06/16] Add XML documentation as additional source so works properly --- src/Documentation/AdditionalReferenceDocumentation.shfbproj | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Documentation/AdditionalReferenceDocumentation.shfbproj b/src/Documentation/AdditionalReferenceDocumentation.shfbproj index a382d1f30..d8d1f7cd9 100644 --- a/src/Documentation/AdditionalReferenceDocumentation.shfbproj +++ b/src/Documentation/AdditionalReferenceDocumentation.shfbproj @@ -28,7 +28,9 @@ + +