NC: Strip leading "Rep. " and "Sen. " from committee members to help with matching #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with matching This strips leading "Rep. " and "Sen. " from committee members to help with name matching. NameMatcher seems like it is treating "Rep. Adams", for example, as a person whose first name is "Rep. ". This silences the warning "No matches for" for all but two members, "Brenden Jones", who is listed as "Brendan H. Jones" on the legislators page, and "R.Turner".
|
Lower house committee debug logs Without change: With change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strips leading "Rep. " and "Sen. " from committee members to help with name matching. NameMatcher seems like it is treating "Rep. Adams", for example, as a person whose first name is "Rep. ".
This silences the warning "No matches for" for all but two members. Member "Brenden Jones" should match Rep. Brendan H. Jones, and member "R.Turner" should match Rep. Rena W. Turner.
Close #1342.