Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update accounts API call #2

Merged
merged 1 commit into from Mar 17, 2014

Conversation

Projects
None yet
3 participants
Member

karenc commented Mar 5, 2014

No description provided.

Member

karenc commented Mar 6, 2014

Now using /api/users/me.json instead.

@jpslav jpslav and 1 other commented on an outdated diff Mar 6, 2014

lib/omniauth/strategies/openstax.rb
info do
{
username: raw_info["username"],
- first_name: raw_info["first_name"],
@jpslav

jpslav Mar 6, 2014

Owner

Why remove first_name and last_name?

@karenc

karenc Mar 7, 2014

Member

I thought you removed it from the api...

@jpslav

jpslav Mar 7, 2014

Owner

No don't think so. Sorry if I gave you that impression.

On Mar 7, 2014, at 1:12 AM, Karen Chan notifications@github.com wrote:

In lib/omniauth/strategies/openstax.rb:

   info do
     {
       username: raw_info["username"],
  •      first_name: raw_info["first_name"],
    
    I thought you removed it from the api...


Reply to this email directly or view it on GitHub.

Member

karenc commented Mar 7, 2014

Updated to not remove first name and last name

@edwoodward edwoodward added a commit that referenced this pull request Mar 17, 2014

@edwoodward edwoodward Merge pull request #2 from karenc/accounts-api-update
Update accounts API call
fc5292b

@edwoodward edwoodward merged commit fc5292b into openstax:master Mar 17, 2014

@karenc karenc deleted the karenc:accounts-api-update branch Mar 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment