Disable ActiveStorage routes since we currently do not use them #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedstrm
reviewed
Jun 18, 2019
Contributor
reedstrm
left a comment
reedstrm
left a comment
There was a problem hiding this comment.
Rather than deleting the routes after they've been created, can't we just comment out (or delete) config/storage.yml?
Contributor
|
Hmm, seems it's a bit more convoluted than that:
|
Member
Author
|
Closing. We'll merge #261 instead. |
meeragovindaraju
removed this from the
Release 2019-07-01; Code Freeze 2019-06-21 milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing we missed during the Rails 5 upgrade. I'll do the same in Tutor.
These routes currently don't work anyway because Rails puts them after the catch-all FE route.