Skip to content

Don't error when an exercise has a blank cnxmod or cnxfeature tag #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Don't error when an exercise has a blank cnxmod or cnxfeature tag #357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd9b244
Don't error when an exercise has a blank cnxmod or cnxfeature tag
Dantemss Mar 8, 2022
a50b64b
Also skip checking blank page_uuids in set_slug_tags
Dantemss Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/models/exercise.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,16 @@ def set_context(archive_version: nil)
archive = OpenStax::Content::Archive.new version: archive_version
cnxmod_tags.each do |cnxmod_tag|
page_uuid = cnxmod_tag.sub 'context-cnxmod:', ''
next if page_uuid.blank?

page = s3.find_page page_uuid, archive_version: archive_version
next if page.nil?

node = Nokogiri::HTML.parse archive.json(page)['content']
cnxfeature_tags.each do |cnxfeature_tag|
feature_id = cnxfeature_tag.sub 'context-cnxfeature:', ''
next if feature_id.blank?

feature = node.at_css "##{feature_id}"
next if feature.nil?

Expand Down Expand Up @@ -255,7 +259,7 @@ def set_slug_tags

page_uuids = non_slug_tags.map(&:name).filter do |name|
name.starts_with? 'context-cnxmod:'
end.map { |cnxmod| cnxmod.sub 'context-cnxmod:', '' }
end.map { |cnxmod| cnxmod.sub 'context-cnxmod:', '' }.reject(&:blank?)

desired_slug_hashes = page_uuids.flat_map do |page_uuid|
Content.slugs_by_page_uuid[page_uuid] || []
Expand Down