CORE-829 Add login gate #2585
Merged
CORE-829 Add login gate #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
core-829-add-login-gate-to-some-books
branch
from
108ceb1 to
c11ba5b
Compare
jivey
reviewed
Oct 28, 2025
There was a problem hiding this comment.
Code changes seem good, I am wondering about the general design. The login button looks a little strange because of the block style:
I'm also wondering if we are okay with search still working... granted the results don't show very much, but making sure that's not an issue.
|
That's not how it's supposed to render. It should look like this. Looks like I need to adjust for Safari. |
|
I included TopBar in the gate so the search bar isn't displayed. It won't prevent URL-hacking to get search results, but I don't think that's a real concern. |
jivey
approved these changes
Oct 28, 2025
RoyEJohnson
force-pushed
the
core-829-add-login-gate-to-some-books
branch
from
3582cbe to
aa28550
Compare
TomWoodward
had a problem deploying
to
rex-web-core-829-add-lo-vvixw7
RoyEJohnson
force-pushed
the
core-829-add-login-gate-to-some-books
branch
from
ef7e1b0 to
d7294a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-829
I implemented this so that the login message replaces the page content, rather than as a dialog.